Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3748)

Unified Diff: chrome/browser/ui/views/desktop_media_picker_views.h

Issue 393653004: Add unit tests for DesktopMediaPickerViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/desktop_media_picker_views.h
diff --git a/chrome/browser/ui/views/desktop_media_picker_views.h b/chrome/browser/ui/views/desktop_media_picker_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..0be9ad487cb4e263b3b66e678ceebd5c7ce81109
--- /dev/null
+++ b/chrome/browser/ui/views/desktop_media_picker_views.h
@@ -0,0 +1,185 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
+
+#include "chrome/browser/media/desktop_media_list_observer.h"
+#include "chrome/browser/media/desktop_media_picker.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace views {
+class ImageView;
+class Label;
+} // namespace views
+
+class DesktopMediaPickerDialogView;
+class DesktopMediaPickerViews;
+class DesktopMediaSourceView;
+
+// View that shows list of desktop media sources available from
msw 2014/07/15 03:29:56 nit: "a list"
+// DesktopMediaList.
+class DesktopMediaListView : public views::View,
+ public DesktopMediaListObserver {
+ public:
+ DesktopMediaListView(DesktopMediaPickerDialogView* parent,
+ scoped_ptr<DesktopMediaList> media_list);
+ virtual ~DesktopMediaListView();
+
+ void StartUpdating(content::DesktopMediaID::Id dialog_window_id);
+
+ // Called by DesktopMediaSourceView when selection has changed.
+ void OnSelectionChanged();
+
+ // Called by DesktopMediaSourceView when a source has been double-clicked.
+ void OnDoubleClick();
+
+ // Returns currently selected source.
+ DesktopMediaSourceView* GetSelection();
+
+ // views::View overrides.
+ virtual gfx::Size GetPreferredSize() const OVERRIDE;
+ virtual void Layout() OVERRIDE;
+ virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
+
+ private:
+ // DesktopMediaList::Observer interface
+ virtual void OnSourceAdded(int index) OVERRIDE;
+ virtual void OnSourceRemoved(int index) OVERRIDE;
+ virtual void OnSourceMoved(int old_index, int new_index) OVERRIDE;
+ virtual void OnSourceNameChanged(int index) OVERRIDE;
+ virtual void OnSourceThumbnailChanged(int index) OVERRIDE;
+
+ DesktopMediaPickerDialogView* parent_;
+ scoped_ptr<DesktopMediaList> media_list_;
+
+ DISALLOW_COPY_AND_ASSIGN(DesktopMediaListView);
+};
+
+// View used for each item in DesktopMediaListView. Shows a single desktop media
+// source as a thumbnail with the title under it.
+class DesktopMediaSourceView : public views::View {
+ public:
+ DesktopMediaSourceView(DesktopMediaListView* parent,
+ content::DesktopMediaID source_id);
+ virtual ~DesktopMediaSourceView();
+
+ // Updates thumbnail and title from |source|.
+ void SetName(const base::string16& name);
+ void SetThumbnail(const gfx::ImageSkia& thumbnail);
+
+ // Id for the source shown by this View.
+ const content::DesktopMediaID& source_id() const { return source_id_; }
+
+ // Returns true if the source is selected.
+ bool is_selected() const { return selected_; }
+
+ // views::View interface.
+ virtual const char* GetClassName() const OVERRIDE;
+ virtual void Layout() OVERRIDE;
+ virtual views::View* GetSelectedViewForGroup(int group) OVERRIDE;
+ virtual bool IsGroupFocusTraversable() const OVERRIDE;
+ virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
+ virtual void OnFocus() OVERRIDE;
+ virtual void OnBlur() OVERRIDE;
+ virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
+ virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
+
+ private:
+ // Updates selection state of the element. If |selected| is true then also
+ // calls SetSelected(false) for the source view that was selected before that
+ // (if any).
+ void SetSelected(bool selected);
+
+ DesktopMediaListView* parent_;
+ content::DesktopMediaID source_id_;
+
+ views::ImageView* image_view_;
+ views::Label* label_;
+
+ bool selected_;
+
+ DISALLOW_COPY_AND_ASSIGN(DesktopMediaSourceView);
+};
+
+// Dialog view used for DesktopMediaPickerViews.
+class DesktopMediaPickerDialogView : public views::DialogDelegateView {
+ public:
+ DesktopMediaPickerDialogView(content::WebContents* parent_web_contents,
+ gfx::NativeWindow context,
+ gfx::NativeWindow parent_window,
+ DesktopMediaPickerViews* parent,
+ const base::string16& app_name,
+ const base::string16& target_name,
+ scoped_ptr<DesktopMediaList> media_list);
+ virtual ~DesktopMediaPickerDialogView();
+
+ // Called by parent (DesktopMediaPickerViews) when it's destroyed.
+ void DetachParent();
+
+ // Called by DesktopMediaListView.
+ void OnSelectionChanged();
+ void OnDoubleClick();
+
+ // views::View overrides.
+ virtual gfx::Size GetPreferredSize() const OVERRIDE;
+ virtual void Layout() OVERRIDE;
+
+ // views::DialogDelegateView overrides.
+ virtual ui::ModalType GetModalType() const OVERRIDE;
+ virtual base::string16 GetWindowTitle() const OVERRIDE;
+ virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
+ virtual base::string16 GetDialogButtonLabel(
+ ui::DialogButton button) const OVERRIDE;
+ virtual bool Accept() OVERRIDE;
+ virtual void DeleteDelegate() OVERRIDE;
+
+ void OnMediaListRowsChanged();
+
+ DesktopMediaSourceView* GetMediaSourceViewForTesting(int index) const;
+
+ private:
+ DesktopMediaPickerViews* parent_;
+ base::string16 app_name_;
+
+ views::Label* label_;
+ views::ScrollView* scroll_view_;
+ DesktopMediaListView* list_view_;
+
+ DISALLOW_COPY_AND_ASSIGN(DesktopMediaPickerDialogView);
+};
+
+// Implementation of DesktopMediaPicker for Views.
+class DesktopMediaPickerViews : public DesktopMediaPicker {
+ public:
+ DesktopMediaPickerViews();
+ virtual ~DesktopMediaPickerViews();
+
+ void NotifyDialogResult(content::DesktopMediaID source);
+
+ // DesktopMediaPicker overrides.
+ virtual void Show(content::WebContents* web_contents,
+ gfx::NativeWindow context,
+ gfx::NativeWindow parent,
+ const base::string16& app_name,
+ const base::string16& target_name,
+ scoped_ptr<DesktopMediaList> media_list,
+ const DoneCallback& done_callback) OVERRIDE;
+
+ DesktopMediaPickerDialogView* GetDialogViewForTesting() const {
+ return dialog_;
+ }
+
+ private:
+ DoneCallback callback_;
+
+ // The |dialog_| is owned by the corresponding views::Widget instance.
+ // When DesktopMediaPickerViews is destroyed the |dialog_| is destroyed
+ // asynchronously by closing the widget.
+ DesktopMediaPickerDialogView* dialog_;
+
+ DISALLOW_COPY_AND_ASSIGN(DesktopMediaPickerViews);
+};
+
+#endif // CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_

Powered by Google App Engine
This is Rietveld 408576698