Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 39363002: Optimize ParamTraits<float> and ParamTraits<double> (Closed)

Created:
7 years, 2 months ago by piman
Modified:
7 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, danakj
Visibility:
Public.

Description

Optimize ParamTraits<float> and ParamTraits<double> These function become hot on some benchmarks. WriteData is inefficient because it writes the length, even though it's known on the reader side (compile-time constant). For <float> we can simply use WriteFloat. For <double> we can use WriteBytes instead of WriteData. BUG=307480 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232060

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M ipc/ipc_message_utils.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +2 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
7 years, 2 months ago (2013-10-24 05:18:34 UTC) #1
jam
lgtm if you change the serialization format, you need to update the reference_builds http://src.chromium.org/viewvc/chrome/trunk/deps/reference_builds/
7 years, 2 months ago (2013-10-24 16:17:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/39363002/90001
7 years, 1 month ago (2013-10-31 04:57:04 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 09:27:32 UTC) #4
Message was sent while issue was closed.
Change committed as 232060

Powered by Google App Engine
This is Rietveld 408576698