Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 393593002: Mojo: Mojom: Use super() in the AST code. (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Mojom: Use super() in the AST code. The python 2.x super() is super annoying, but using it is (arguably) slightly less fragile than just calling the superclass's methods directly. Also, make the various __eq__()s call their super's __eq__() (except for NodeBase). R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283191

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 10 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-14 19:10:44 UTC) #1
DaveMoore
lgtm
6 years, 5 months ago (2014-07-15 00:19:44 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 5 months ago (2014-07-15 01:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/393593002/1
6 years, 5 months ago (2014-07-15 01:20:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 07:22:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 07:24:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28660)
6 years, 5 months ago (2014-07-15 07:24:39 UTC) #7
viettrungluu
6 years, 5 months ago (2014-07-15 15:31:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r283191 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698