Enabling ActivityLogApiTest.TriggerEvent after Activity Log refactoring.

Enabling ActivityLogApiTest.TriggerEvent after Activity Log refactoring.

BUG=388289
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283802

[pmarch, 2014-07-14 18:42:18]

Michael, Devlin, a small CL for review. Thanks.

[pmarch, 2014-07-15 10:32:45]

Hi Adrienne,

Michael is OOO, can you look at this CL.

Thanks

[felt, 2014-07-15 16:42:53]

https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc
(right):

https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc:50:
// TODO(karenlees): fix flakiness on win debug - crbug.com/299393
why is this TODO being reassigned from pmarch to karenlees?

[pmarch, 2014-07-15 18:26:36]

On 2014/07/15 16:42:53, felt wrote:
>
https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
> File
>
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc
> (right):
> 
>
https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
>
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc:50:
> // TODO(karenlees): fix flakiness on win debug - crbug.com/299393
> why is this TODO being reassigned from pmarch to karenlees?

It was there before I disabled the test with this CL
https://codereview.chromium.org/352583004/

BTW, I will try to enable this test on Windows in another CL and see if it is
still flaky.

[felt, 2014-07-16 17:15:05]

On 2014/07/15 18:26:36, pmarch wrote:
> On 2014/07/15 16:42:53, felt wrote:
> >
>
https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
> > File
> >
>
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
> >
>
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc:50:
> > // TODO(karenlees): fix flakiness on win debug - crbug.com/299393
> > why is this TODO being reassigned from pmarch to karenlees?
> 
> It was there before I disabled the test with this CL
> https://codereview.chromium.org/352583004/
> 
> BTW, I will try to enable this test on Windows in another CL and see if it is
> still flaky.

ah OK. lgtm, but can I convince you to take over ownership of that TODO/bug?

[Devlin, 2014-07-16 20:10:08]

lgtm

[pmarch, 2014-07-17 13:25:23]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-07-17 13:25:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/393583002/20001

[pmarch, 2014-07-17 13:26:04]

On 2014/07/16 17:15:05, felt wrote:
> On 2014/07/15 18:26:36, pmarch wrote:
> > On 2014/07/15 16:42:53, felt wrote:
> > >
> >
>
https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
> > > File
> > >
> >
>
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/393583002/diff/1/chrome/browser/extensions/ap...
> > >
> >
>
chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc:50:
> > > // TODO(karenlees): fix flakiness on win debug - crbug.com/299393
> > > why is this TODO being reassigned from pmarch to karenlees?
> > 
> > It was there before I disabled the test with this CL
> > https://codereview.chromium.org/352583004/
> > 
> > BTW, I will try to enable this test on Windows in another CL and see if it
is
> > still flaky.
> 
> ah OK. lgtm, but can I convince you to take over ownership of that TODO/bug?

I took the bug ownership, and will investigate it in the next CL

[commit-bot: I haz the power, 2014-07-17 17:22:01]

Change committed as 283802