Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: Source/core/html/HTMLMarqueeElement.js

Issue 393543002: Reflected attributes should be removed when 'null', 'undefined' or 'false' is specified (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/html/marquee-element-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMarqueeElement.js
diff --git a/Source/core/html/HTMLMarqueeElement.js b/Source/core/html/HTMLMarqueeElement.js
index 3ca0e32892c0144609d39a3b742d80071620fc7c..f9cc913be75737536e4ab90314a60b844ff12b22 100644
--- a/Source/core/html/HTMLMarqueeElement.js
+++ b/Source/core/html/HTMLMarqueeElement.js
@@ -62,10 +62,10 @@ installClass('HTMLMarqueeElement', function(global) {
return this.hasAttribute(attributeName);
},
set: function(value) {
- if (value.valueOf() === false)
- this.removeAttribute(attributeName);
+ if (value)
+ this.setAttribute(attributeName, '');
else
- this.setAttribute(attributeName, value ? '' : null);
+ this.removeAttribute(attributeName);
},
});
}
« no previous file with comments | « LayoutTests/fast/html/marquee-element-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698