Source/modules/geolocation/GeofencingRegion.h - Issue 393533002: Pass through the geofencing API calls to the content layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/GeofencingRegion.h

Issue 393533002: Pass through the geofencing API calls to the content layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@geofencing2

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/geolocation/GeofencingError.cpp ('k') | Source/modules/geolocation/Geolocation.cpp » ('j') | Source/modules/geolocation/Geolocation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/GeofencingRegion.h

diff --git a/Source/modules/geolocation/GeofencingRegion.h b/Source/modules/geolocation/GeofencingRegion.h

index 6a0256ee8f88fb666deb74fde13a0d42473bca39..225947b72301a82ef9424ce6f7764e162d21010a 100644

--- a/Source/modules/geolocation/GeofencingRegion.h

+++ b/Source/modules/geolocation/GeofencingRegion.h

@@ -18,6 +18,8 @@ public:

String id() const { return m_id; }

+ virtual bool isCircularRegion() const { return false; }

Michael van Ouwerkerk 2014/07/15 18:04:41 This seems to violate basic object oriented design

virtual void trace(Visitor*) { }

protected:

« no previous file with comments | « Source/modules/geolocation/GeofencingError.cpp ('k') | Source/modules/geolocation/Geolocation.cpp » ('j') | Source/modules/geolocation/Geolocation.cpp » ('J')