Issue 39353003: Web Animations CSS: Add transitions tests to virtual/web-animations-css

Issue 39353003: Web Animations CSS: Add transitions tests to virtual/web-animations-css (Closed)

Created:
7 years, 2 months ago by dstockwell

Modified:
7 years, 2 months ago

Reviewers:
Timothy Loh, Steve Block

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations CSS: Add transitions tests to virtual/web-animations-css BUG=271815 NOTRY=tried Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160435

Patch Set 2 : Crashes from debug #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -7 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
A +	LayoutTests/virtual/web-animations-css/transitions/cubic-bezier-overflow-svg-length-expected.txt	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	LayoutTests/virtual/web-animations-css/transitions/flex-transitions-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/virtual/web-animations-css/transitions/repeated-firing-background-color-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	LayoutTests/virtual/web-animations-css/transitions/svg-transitions-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	LayoutTests/virtual/web-animations-css/transitions/zero-duration-with-non-zero-delay-start-expected.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Timothy Loh

lgtm https://codereview.chromium.org/39353003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/39353003/diff/1/LayoutTests/TestExpectations#newcode195 LayoutTests/TestExpectations:195: crbug.com/303430 virtual/web-animations-css/transitions/shadow.html [ Crash ] I'm not too ...

7 years, 2 months ago (2013-10-24 05:29:03 UTC) #3

Steve Block

https://codereview.chromium.org/39353003/diff/1/LayoutTests/virtual/web-animations-css/transitions/svg-transitions-expected.txt File LayoutTests/virtual/web-animations-css/transitions/svg-transitions-expected.txt (right): https://codereview.chromium.org/39353003/diff/1/LayoutTests/virtual/web-animations-css/transitions/svg-transitions-expected.txt#newcode1 LayoutTests/virtual/web-animations-css/transitions/svg-transitions-expected.txt:1: PASS - "fill-opacity" property for "rect1" element at 1s ...

7 years, 2 months ago (2013-10-24 05:30:53 UTC) #4

dstockwell

On 2013/10/24 05:30:53, Steve Block wrote: > Do you need this expected result? - you ...

7 years, 2 months ago (2013-10-24 05:33:36 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/39353003/90001

7 years, 2 months ago (2013-10-24 08:42:56 UTC) #6

Message was sent while issue was closed.

Change committed as 160435

Expand Messages | Collapse Messages