Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 393403003: roll pdfium 532a6a7ece21ca4ea253a196bb5c61a1861d12a0:0ce77e3c04dd17d3086adfc8781a2155fb9ceb69 (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

roll pdfium 532a6a7ece21ca4ea253a196bb5c61a1861d12a0:0ce77e3c04dd17d3086adfc8781a2155fb9ceb69 This brings in: 0ce77e3 Add a newline at the end of fpdfeditpage.cpp. 27e35a8 Remove uninitialized const global g_GbFontNameMap. b44bac5 Error handling for invalid component number in CPDF_ICCBasedCS::v_Load f86d7d6 Fix uninitialized coords in _DrawCoonPatchMeshes 1c8d196 Fix uninitialized nresults in GetRGB feff0db Fix uninitialized RGB in DrawShading 8434565 Fix uninitialized Storage in _LUTeval16 9114e83 Add support to extract viewer preference 8daab31 Fix an out-of-boundary issue for wide string 456cde9 Fix uninitialized Storage fab8896 Fix uninitialized okeybuf 41e06e7 Fix uninitialized triangle d5a0e7a Zero out temporary arrays before use in PDF encryption. b66432c Fix a null object bug BUG=82385, 386728, 391470, 387809, 386730, 387826, 169120, 381521, 387843, 387011, 387835, 387834, 387975 NOTRY=true R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283502

Patch Set 1 #

Patch Set 2 : one more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
(I've never done a pdfium roll before; let me know if there's some protocol I'm ...
6 years, 5 months ago (2014-07-16 18:19:45 UTC) #1
Lei Zhang
We usually have a brief changelog. See previous rolls for examples.
6 years, 5 months ago (2014-07-16 19:17:43 UTC) #2
Lei Zhang
Otherwise lgtm
6 years, 5 months ago (2014-07-16 19:18:15 UTC) #3
Nico
Thanks. I added a log, and rolled in one more revision.
6 years, 5 months ago (2014-07-16 20:34:38 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-16 20:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/393403003/20001
6 years, 5 months ago (2014-07-16 20:37:28 UTC) #6
Nico
6 years, 5 months ago (2014-07-16 21:06:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r283502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698