Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 393403002: Update SourceBufferStream and its unit tests to always expect valid durations. (Closed)

Created:
6 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 5 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update SourceBufferStream and its unit tests to always expect valid durations. This change fixes the SourceBufferStream unit tests so that they always provide valid durations for buffers that it passes to SourceBufferStream. I've also added code to SoureBufferStream to verify that it always gets buffers with valid durations. Minor tweaks to test expectations were needed to compensate for the SourceBufferStream behaving differently when it got actual durations instead of using the durations it made up. In most cases I just used the duration the SourceBufferStream was ultimately using. In a few cases the duration the SourceBufferStream was generating didn't make any sense so I simply changed the expectations to match the new behavior. This is an attempt to reland https://codereview.chromium.org/379693002/ with appropriate crash fixes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283754

Patch Set 1 : Original patch #

Patch Set 2 : Add negative duration guard to avoid crashing when FFmpeg returns negative durations. #

Total comments: 3

Patch Set 3 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -73 lines) Patch
M media/base/decoder_buffer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/stream_parser_buffer.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 39 chunks +95 lines, -71 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/393403002/diff/20001/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/393403002/diff/20001/media/filters/ffmpeg_demuxer.cc#newcode285 media/filters/ffmpeg_demuxer.cc:285: DVLOG(1) << "FFmpeg returned a buffer with a negative ...
6 years, 5 months ago (2014-07-16 18:17:46 UTC) #1
wolenetz
lgtm % nit https://codereview.chromium.org/393403002/diff/20001/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/393403002/diff/20001/media/filters/ffmpeg_demuxer.cc#newcode285 media/filters/ffmpeg_demuxer.cc:285: DVLOG(1) << "FFmpeg returned a buffer ...
6 years, 5 months ago (2014-07-16 19:51:03 UTC) #2
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/393403002/diff/20001/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/393403002/diff/20001/media/filters/ffmpeg_demuxer.cc#newcode285 media/filters/ffmpeg_demuxer.cc:285: DVLOG(1) << "FFmpeg returned a buffer with a negative ...
6 years, 5 months ago (2014-07-16 19:54:55 UTC) #3
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 5 months ago (2014-07-16 19:54:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/393403002/40001
6 years, 5 months ago (2014-07-16 19:57:55 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 11:25:00 UTC) #6
Message was sent while issue was closed.
Change committed as 283754

Powered by Google App Engine
This is Rietveld 408576698