Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 39337: Reduced the code sequence for testing for object type....

Created:
11 years, 9 months ago by bak
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Reduced the code sequence for testing for object type. We now use cmpb instead of movzx_b and cmp.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -62 lines) Patch
M src/builtins-ia32.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M src/codegen-ia32.cc View 6 chunks +7 lines, -21 lines 0 comments Download
M src/ic-ia32.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M src/macro-assembler-ia32.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/macro-assembler-ia32.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M src/stub-cache-ia32.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/virtual-frame-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bak
11 years, 9 months ago (2009-03-09 13:35:14 UTC) #1
Kasper Lund
11 years, 9 months ago (2009-03-09 13:48:06 UTC) #2
Go, go, go! LGTM.

Powered by Google App Engine
This is Rietveld 408576698