Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: Source/modules/webaudio/AudioListener.h

Issue 393363002: Move handle of HRTFDatabaseLoader to AudioListener. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webaudio/AudioListener.cpp » ('j') | Source/modules/webaudio/PannerNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioListener.h
diff --git a/Source/modules/webaudio/AudioListener.h b/Source/modules/webaudio/AudioListener.h
index 214db390b700f960513c7b408f0d190be05c3f2e..fdd43a4d1ebb288dd4e412f3445fc2a5af0453be 100644
--- a/Source/modules/webaudio/AudioListener.h
+++ b/Source/modules/webaudio/AudioListener.h
@@ -38,6 +38,7 @@
namespace WebCore {
+class HRTFDatabaseLoader;
class PannerNode;
// AudioListener maintains the state of the listener in the audio scene as defined in the OpenAL specification.
@@ -79,6 +80,9 @@ public:
void addPanner(PannerNode*);
void removePanner(PannerNode*);
+ void setHRTFDatabaseLoader(PassRefPtrWillBeRawPtr<HRTFDatabaseLoader>);
tkent 2014/07/16 23:32:25 PassRefPtrWIllBeRawPtr should be PassRefPtr becaus
KhNo 2014/07/17 16:23:17 Done.
+ HRTFDatabaseLoader* hrtfDatabaseLoader() { return m_hrtfDatabaseLoader.get(); }
+
void trace(Visitor*) { }
private:
@@ -100,9 +104,11 @@ private:
// Synchronize a panner's process() with setting of the state of the listener.
mutable Mutex m_listenerLock;
-
// List for pannerNodes in context.
Vector<PannerNode*> m_panners;
+ // HRTF DB loader for panner node. It should be allocated once on constructor of panner node,
Raymond Toy 2014/07/16 16:35:38 How do you enforce that it is allocated only once
KhNo 2014/07/17 16:23:17 Yes, you right. I missed it. Basically it should b
+ // then keep handle for efficiant loading.
Raymond Toy 2014/07/16 16:35:38 Typo: efficiant -> efficient
KhNo 2014/07/17 16:23:17 Done.
+ RefPtrWillBeRawPtr<HRTFDatabaseLoader> m_hrtfDatabaseLoader;
tkent 2014/07/16 23:32:25 RefPtrWillBeRawPtr should be RefPtr.
KhNo 2014/07/17 16:23:17 Thanks for comment. :) Done.
};
} // WebCore
« no previous file with comments | « no previous file | Source/modules/webaudio/AudioListener.cpp » ('j') | Source/modules/webaudio/PannerNode.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698