Issue 39336: Refactored the code for comparing the type of an object with a constant....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39336: Refactored the code for comparing the type of an object with a constant....

Created:
11 years, 9 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/global/

Visibility:
Public.

Description

Refactored the code for comparing the type of an object with a constant. We now use cmpb instead of movzx_b & cmp.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -64 lines)			Patch
M	src/builtins-ia32.cc	View	4 chunks	+4 lines, -11 lines	1 comment	Download
M	src/codegen-ia32.cc	View	6 chunks	+7 lines, -21 lines	0 comments	Download
M	src/ic-ia32.cc	View	4 chunks	+4 lines, -11 lines	0 comments	Download
M	src/macro-assembler-ia32.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/macro-assembler-ia32.cc	View	3 chunks	+15 lines, -6 lines	0 comments	Download
M	src/stub-cache-ia32.cc	View	4 chunks	+4 lines, -12 lines	0 comments	Download
M	src/virtual-frame-ia32.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 9 months ago (2009-03-09 13:17:59 UTC) #2

LGTM. Maybe you should apply the patch to the bleeding_edge branch instead of
the experimental one?

http://codereview.chromium.org/39336/diff/1/5
File src/builtins-ia32.cc (right):

http://codereview.chromium.org/39336/diff/1/5#newcode389
Line 389: __ CmpObjectType(edi,JS_FUNCTION_TYPE, ecx);
Missing space before JS_FUNCTION_TYPE.

Expand Messages | Collapse Messages