Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 393343002: Rename "managed (mode|user)" to "supervised user" (part 7) (Closed)

Created:
6 years, 5 months ago by Marc Treib
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, pam+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Pam (message me for reviews), Bernhard Bauer
Project:
chromium
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 7) Followup to https://codereview.chromium.org/384023002/ This CL renames ChromeOS-specific code. Still missing: - ChromeOS-specific resource IDs (strings and images) - JavaScript, HTML, CSS - The global ENABLE_MANAGED_USERS define TBR=atwilson@chromium.org (c/b/signin) TBR=nkostylev@chromium.org (c/b/chromeos) TBR=noms@chromium.org (c/b/profiles) TBR=oshima@chromium.org (ash and c/b/ui/ash) All TBRs are simple renamings. BUG=385113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284078

Patch Set 1 #

Total comments: 16

Patch Set 2 : alphabetize (and rebase) #

Total comments: 6

Patch Set 3 : more alphabetize (and rebase again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+847 lines, -5604 lines) Patch
M ash/ash.gyp View 1 4 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/chromeos/managed/tray_locally_managed_user.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ash/system/chromeos/managed/tray_locally_managed_user.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D ash/system/chromeos/managed/tray_locally_managed_user_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
A + ash/system/chromeos/supervised/tray_supervised_user.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + ash/system/chromeos/supervised/tray_supervised_user.cc View 5 chunks +16 lines, -16 lines 0 comments Download
A + ash/system/chromeos/supervised/tray_supervised_user_unittest.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/system_notifier.h View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/system/system_notifier.cc View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ash/system/user/login_status.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/authenticator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/auth/mock_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/mock_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_screen_policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/login/managed/locally_managed_user_constants.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/chromeos/login/managed/locally_managed_user_constants.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.h View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc View 1 chunk +0 lines, -597 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_authenticator.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_authenticator.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_creation_browsertest.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_creation_controller.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_creation_controller.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.h View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc View 1 chunk +0 lines, -402 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_password_browsertest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_test_base.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/chromeos/login/managed/managed_user_test_base.cc View 1 chunk +0 lines, -436 lines 0 comments Download
D chrome/browser/chromeos/login/managed/supervised_user_authentication.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/chromeos/login/managed/supervised_user_authentication.cc View 1 chunk +0 lines, -321 lines 0 comments Download
D chrome/browser/chromeos/login/managed/supervised_user_authentication_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/chromeos/login/managed/supervised_user_login_flow.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/chromeos/login/managed/supervised_user_login_flow.cc View 1 chunk +0 lines, -258 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/screen_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/screen_factory.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_authentication.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_authentication_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_authenticator.h View 5 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc View 16 chunks +59 lines, -53 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc View 2 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.h View 4 chunks +13 lines, -15 lines 0 comments Download
A chrome/browser/chromeos/login/supervised/supervised_user_creation_controller.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h View 8 chunks +22 lines, -22 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc View 14 chunks +44 lines, -39 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc View 5 chunks +16 lines, -16 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h View 7 chunks +26 lines, -26 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 24 chunks +60 lines, -61 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_test_base.h View 5 chunks +13 lines, -13 lines 0 comments Download
A + chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc View 20 chunks +29 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_supervised_user_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc View 13 chunks +46 lines, -50 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/user.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 1 13 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/chromeos/manager_password_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/chromeos/supervised_user_password_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/chromeos/supervised_user_password_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_linux.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.cc View 1 chunk +0 lines, -455 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 8 chunks +24 lines, -24 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 13 chunks +61 lines, -64 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 chunks +16 lines, -16 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/login_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/login_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/user_names.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/login/user_names.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user_type.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Marc Treib
Hi Nikita, PTAL when you have a moment!
6 years, 5 months ago (2014-07-16 16:10:30 UTC) #1
Nikita (slow)
I'd leave this review to Denis. Please let me know once you'll need owners review ...
6 years, 5 months ago (2014-07-16 16:15:25 UTC) #2
Marc Treib
On 2014/07/16 16:15:25, Nikita Kostylev wrote: > I'd leave this review to Denis. > > ...
6 years, 5 months ago (2014-07-16 16:18:19 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 5 months ago (2014-07-16 17:01:59 UTC) #4
Pam (message me for reviews)
Nothing substantive, just marking some re-alphabetization. https://codereview.chromium.org/393343002/diff/1/ash/system/system_notifier.cc File ash/system/system_notifier.cc (right): https://codereview.chromium.org/393343002/diff/1/ash/system/system_notifier.cc#newcode29 ash/system/system_notifier.cc:29: kNotifierSupervisedUser, It looks ...
6 years, 5 months ago (2014-07-16 18:12:36 UTC) #5
Marc Treib
https://codereview.chromium.org/393343002/diff/1/ash/system/system_notifier.cc File ash/system/system_notifier.cc (right): https://codereview.chromium.org/393343002/diff/1/ash/system/system_notifier.cc#newcode29 ash/system/system_notifier.cc:29: kNotifierSupervisedUser, On 2014/07/16 18:12:36, Pam (also PM for reviews) ...
6 years, 5 months ago (2014-07-17 08:58:39 UTC) #6
Pam (message me for reviews)
lgtm with a couple more ABCs noted. https://codereview.chromium.org/393343002/diff/20001/ash/system/system_notifier.cc File ash/system/system_notifier.cc (right): https://codereview.chromium.org/393343002/diff/20001/ash/system/system_notifier.cc#newcode27 ash/system/system_notifier.cc:27: kNotifierDisplayError, Also ...
6 years, 5 months ago (2014-07-17 16:48:48 UTC) #7
Marc Treib
https://codereview.chromium.org/393343002/diff/20001/ash/system/system_notifier.cc File ash/system/system_notifier.cc (right): https://codereview.chromium.org/393343002/diff/20001/ash/system/system_notifier.cc#newcode27 ash/system/system_notifier.cc:27: kNotifierDisplayError, On 2014/07/17 16:48:47, Pam (also PM for reviews) ...
6 years, 5 months ago (2014-07-18 08:07:07 UTC) #8
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 5 months ago (2014-07-18 08:07:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/393343002/40001
6 years, 5 months ago (2014-07-18 08:08:40 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 11:12:57 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 13:27:04 UTC) #12
Message was sent while issue was closed. 
Change committed as 284078

Powered by Google App Engine
This is Rietveld 408576698