Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 393313004: Fold DecoderStream::Stop() into the dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_impl.h ('k') | media/filters/decoder_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index e6937fc57834e482064fcd1ee19d1a8d3022dfa1..bbe0d786b98472e2492063e8c35907432d6a9ca4 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -48,9 +48,9 @@ AudioRendererImpl::AudioRendererImpl(
AudioHardwareConfig* hardware_config)
: task_runner_(task_runner),
sink_(sink),
- audio_buffer_stream_(task_runner,
- decoders.Pass(),
- set_decryptor_ready_cb),
+ audio_buffer_stream_(new AudioBufferStream(task_runner,
+ decoders.Pass(),
+ set_decryptor_ready_cb)),
hardware_config_(hardware_config),
state_(kUninitialized),
buffering_state_(BUFFERING_HAVE_NOTHING),
@@ -60,9 +60,9 @@ AudioRendererImpl::AudioRendererImpl(
received_end_of_stream_(false),
rendered_end_of_stream_(false),
weak_factory_(this) {
- audio_buffer_stream_.set_splice_observer(base::Bind(
+ audio_buffer_stream_->set_splice_observer(base::Bind(
&AudioRendererImpl::OnNewSpliceBuffer, weak_factory_.GetWeakPtr()));
- audio_buffer_stream_.set_config_change_observer(base::Bind(
+ audio_buffer_stream_->set_config_change_observer(base::Bind(
&AudioRendererImpl::OnConfigChange, weak_factory_.GetWeakPtr()));
}
@@ -155,8 +155,8 @@ void AudioRendererImpl::DoFlush_Locked() {
DCHECK(!pending_read_);
DCHECK_EQ(state_, kFlushed);
- audio_buffer_stream_.Reset(base::Bind(&AudioRendererImpl::ResetDecoderDone,
- weak_factory_.GetWeakPtr()));
+ audio_buffer_stream_->Reset(base::Bind(&AudioRendererImpl::ResetDecoderDone,
+ weak_factory_.GetWeakPtr()));
}
void AudioRendererImpl::ResetDecoderDone() {
@@ -215,7 +215,8 @@ void AudioRendererImpl::Stop(const base::Closure& callback) {
sink_ = NULL;
}
- audio_buffer_stream_.Stop(callback);
+ audio_buffer_stream_.reset();
+ task_runner_->PostTask(FROM_HERE, callback);
}
void AudioRendererImpl::StartPlayingFrom(base::TimeDelta timestamp) {
@@ -296,7 +297,7 @@ void AudioRendererImpl::Initialize(DemuxerStream* stream,
audio_clock_.reset(new AudioClock(audio_parameters_.sample_rate()));
- audio_buffer_stream_.Initialize(
+ audio_buffer_stream_->Initialize(
stream,
false,
statistics_cb,
@@ -486,8 +487,8 @@ void AudioRendererImpl::AttemptRead_Locked() {
return;
pending_read_ = true;
- audio_buffer_stream_.Read(base::Bind(&AudioRendererImpl::DecodedAudioReady,
- weak_factory_.GetWeakPtr()));
+ audio_buffer_stream_->Read(base::Bind(&AudioRendererImpl::DecodedAudioReady,
+ weak_factory_.GetWeakPtr()));
}
bool AudioRendererImpl::CanRead_Locked() {
« no previous file with comments | « media/filters/audio_renderer_impl.h ('k') | media/filters/decoder_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698