Fold DecoderStream::Stop() into the dtor.

Fold DecoderStream::Stop() into the dtor.

BUG=349211
TEST=Existing tests pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283713

[xhwang, 2014-07-16 16:52:25]

Here's another one. This CL is based on
https://codereview.chromium.org/395703002/

PTAL!

[scherkus (not reviewing), 2014-07-16 17:49:48]

lgtm

question + nit

https://codereview.chromium.org/393313004/diff/1/media/filters/audio_renderer...
File media/filters/audio_renderer_impl.cc (right):

https://codereview.chromium.org/393313004/diff/1/media/filters/audio_renderer...
media/filters/audio_renderer_impl.cc:219: audio_buffer_stream_.reset();
will we be getting rid of Audio/VideoRenderer::Stop() as well?

if so, will audio_buffer_stream_ go back to being a regular member instead of
head-allocated?

https://codereview.chromium.org/393313004/diff/1/media/filters/decoder_stream.cc
File media/filters/decoder_stream.cc (right):

https://codereview.chromium.org/393313004/diff/1/media/filters/decoder_stream...
media/filters/decoder_stream.cc:66: if(!init_cb_.is_null()) {
formatting (space after if)

https://codereview.chromium.org/393313004/diff/1/media/filters/video_renderer...
File media/filters/video_renderer_impl.cc (right):

https://codereview.chromium.org/393313004/diff/1/media/filters/video_renderer...
media/filters/video_renderer_impl.cc:107: video_frame_stream_.reset();
ditto

[xhwang, 2014-07-16 23:42:41]

rebase only

[xhwang, 2014-07-16 23:45:45]

comments addressed

[xhwang, 2014-07-16 23:45:49]

https://codereview.chromium.org/393313004/diff/1/media/filters/audio_renderer...
File media/filters/audio_renderer_impl.cc (right):

https://codereview.chromium.org/393313004/diff/1/media/filters/audio_renderer...
media/filters/audio_renderer_impl.cc:219: audio_buffer_stream_.reset();
On 2014/07/16 17:49:48, scherkus wrote:
> will we be getting rid of Audio/VideoRenderer::Stop() as well?
> 
> if so, will audio_buffer_stream_ go back to being a regular member instead of
> head-allocated?

Yes, that's the plan. I'd like to do the transition in small steps and this is
some small overhead I have to pay.

https://codereview.chromium.org/393313004/diff/1/media/filters/decoder_stream.cc
File media/filters/decoder_stream.cc (right):

https://codereview.chromium.org/393313004/diff/1/media/filters/decoder_stream...
media/filters/decoder_stream.cc:66: if(!init_cb_.is_null()) {
On 2014/07/16 17:49:48, scherkus wrote:
> formatting (space after if)

Done.

https://codereview.chromium.org/393313004/diff/1/media/filters/video_renderer...
File media/filters/video_renderer_impl.cc (right):

https://codereview.chromium.org/393313004/diff/1/media/filters/video_renderer...
media/filters/video_renderer_impl.cc:107: video_frame_stream_.reset();
On 2014/07/16 17:49:48, scherkus wrote:
> ditto

ditto

[xhwang, 2014-07-16 23:45:58]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:49:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xhwang@chromium.org/393313004/40001

[commit-bot: I haz the power, 2014-07-17 08:32:56]

Change committed as 283713