Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 393273002: Revert "Remove erroneous uses of CXX / CXX_target / CXX_host from gyp." (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Remove erroneous uses of CXX / CXX_target / CXX_host from gyp." This reverts commit r22425 for breaking the Arm debug builder. BUG=384474 TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -76 lines) Patch
M build/android.gypi View 1 chunk +9 lines, -2 lines 0 comments Download
M build/toolchain.gypi View 11 chunks +70 lines, -74 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
6 years, 5 months ago (2014-07-16 09:53:10 UTC) #1
rmcilroy
Committed patchset #1 manually as r22427 (tree was closed).
6 years, 5 months ago (2014-07-16 09:53:39 UTC) #2
Jakob Kummerow
6 years, 5 months ago (2014-07-16 09:54:15 UTC) #3
Message was sent while issue was closed.
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698