Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 393233006: Revert of athena: Rename athena_resources target to athena_pak. (Closed)

Created:
6 years, 5 months ago by waffles
Modified:
6 years, 5 months ago
Reviewers:
tfarina, oshima
CC:
chromium-reviews, sadrul
Project:
chromium
Visibility:
Public.

Description

Revert of athena: Rename athena_resources target to athena_pak. (https://codereview.chromium.org/404683002/) Reason for revert: Breaks Google ChromeOS compile: /bin/python src/build/gyp_chromium' in '/b/build/slave/google-chrome-rel-chromeos/build' Updating projects from gyp files... gyp: Dependency '/b/build/slave/google-chrome-rel-chromeos/build/src/athena/resources/athena_resources.gyp:athena_resources#target' not found while trying to load target /b/build/slave/google-chrome-rel-chromeos/build/src/athena/athena.gyp:athena_unittests#target Original issue's description: > athena: Rename athena_resources target to athena_pak. > > That way we free a slot for when we add an athena_resources.grd. > > BUG=None > TEST=None > R=oshima@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284268 TBR=oshima@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M athena/main/athena_main.gyp View 1 chunk +1 line, -1 line 0 comments Download
M athena/resources/athena_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
waffles
Created Revert of athena: Rename athena_resources target to athena_pak.
6 years, 5 months ago (2014-07-19 01:21:14 UTC) #1
waffles
The CQ bit was unchecked by waffles@chromium.org
6 years, 5 months ago (2014-07-19 01:22:22 UTC) #2
tfarina
Don't revert, I'm committing the fix.
6 years, 5 months ago (2014-07-19 01:22:57 UTC) #3
waffles
6 years, 5 months ago (2014-07-19 01:22:58 UTC) #4
On 2014/07/19 01:21:14, waffles wrote:
> Created Revert of athena: Rename athena_resources target to athena_pak.

tfarina has claimed responsibility for fixing, aborting revert

Powered by Google App Engine
This is Rietveld 408576698