Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 393193003: Disable clang's SLP vectorizer. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Disable clang's SLP vectorizer. It currently generates invalid code, see http://llvm.org/bugs/show_bug.cgi?id=20354 BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284029

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/common.gypi View 1 2 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-18 05:10:23 UTC) #1
darin (slow to review)
https://codereview.chromium.org/393193003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/393193003/diff/1/build/common.gypi#newcode4754 build/common.gypi:4754: ] missing comma here?
6 years, 5 months ago (2014-07-18 05:12:09 UTC) #2
Nico
On 2014/07/18 05:12:09, darin wrote: > https://codereview.chromium.org/393193003/diff/1/build/common.gypi > File build/common.gypi (right): > > https://codereview.chromium.org/393193003/diff/1/build/common.gypi#newcode4754 > ...
6 years, 5 months ago (2014-07-18 05:18:23 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-18 05:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/393193003/20001
6 years, 5 months ago (2014-07-18 05:21:35 UTC) #5
commit-bot: I haz the power
Change committed as 284029
6 years, 5 months ago (2014-07-18 07:32:46 UTC) #6
skobes
FYI, I think this change doesn't quite work. In linux release builds the -fno-slp-vectorize is ...
6 years, 5 months ago (2014-07-18 18:12:47 UTC) #7
Nico
https://codereview.chromium.org/393193003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/393193003/diff/20001/build/common.gypi#newcode3545 build/common.gypi:3545: ], Does it work if you add 'cflags': [ ...
6 years, 5 months ago (2014-07-18 18:40:44 UTC) #8
Nico
6 years, 5 months ago (2014-07-18 19:00:07 UTC) #9
Message was sent while issue was closed.
On 2014/07/18 18:40:44, Nico (away) wrote:
> https://codereview.chromium.org/393193003/diff/20001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/393193003/diff/20001/build/common.gypi#newcod...
> build/common.gypi:3545: ],
> Does it work if you add
> 
>   'cflags': [ '-fno-slp-vectorize' ],
> 
> here?

Follow-up with that change: https://codereview.chromium.org/408523002/

Powered by Google App Engine
This is Rietveld 408576698