| Index: chrome/browser/search/search_unittest.cc
|
| diff --git a/chrome/browser/search/search_unittest.cc b/chrome/browser/search/search_unittest.cc
|
| index 19c4ca2d22d464f15abd2c17943b59e92cfa709a..eb71f05895a348f07a5c7a49c6ef03bf2fa1bf99 100644
|
| --- a/chrome/browser/search/search_unittest.cc
|
| +++ b/chrome/browser/search/search_unittest.cc
|
| @@ -6,7 +6,6 @@
|
| #include "base/metrics/field_trial.h"
|
| #include "base/metrics/histogram_base.h"
|
| #include "base/metrics/histogram_samples.h"
|
| -#include "base/metrics/statistics_recorder.h"
|
| #include "base/prefs/pref_service.h"
|
| #include "base/strings/utf_string_conversions.h"
|
| #include "chrome/browser/search/instant_service.h"
|
| @@ -24,6 +23,7 @@
|
| #include "chrome/test/base/browser_with_test_window_test.h"
|
| #include "chrome/test/base/ui_test_utils.h"
|
| #include "components/google/core/browser/google_switches.h"
|
| +#include "components/search/search.h"
|
| #include "components/search_engines/search_engines_switches.h"
|
| #include "components/search_engines/template_url_service.h"
|
| #include "components/variations/entropy_provider.h"
|
| @@ -36,125 +36,6 @@
|
|
|
| namespace chrome {
|
|
|
| -class EmbeddedSearchFieldTrialTest : public testing::Test {
|
| - protected:
|
| - virtual void SetUp() {
|
| - field_trial_list_.reset(new base::FieldTrialList(
|
| - new metrics::SHA1EntropyProvider("42")));
|
| - base::StatisticsRecorder::Initialize();
|
| - }
|
| -
|
| - private:
|
| - scoped_ptr<base::FieldTrialList> field_trial_list_;
|
| -};
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoEmptyAndValid) {
|
| - FieldTrialFlags flags;
|
| -
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(0ul, flags.size());
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Group77"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(0ul, flags.size());
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoInvalidNumber) {
|
| - FieldTrialFlags flags;
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Group77.2"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(0ul, flags.size());
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoInvalidName) {
|
| - FieldTrialFlags flags;
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Invalid77"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(0ul, flags.size());
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoValidGroup) {
|
| - FieldTrialFlags flags;
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Group77"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(0ul, flags.size());
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoValidFlag) {
|
| - FieldTrialFlags flags;
|
| -
|
| - EXPECT_EQ(9999ul, GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Group77 foo:6"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(1ul, flags.size());
|
| - EXPECT_EQ(6ul, GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoNewName) {
|
| - FieldTrialFlags flags;
|
| -
|
| - EXPECT_EQ(9999ul, GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Group77 foo:6"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(1ul, flags.size());
|
| - EXPECT_EQ(6ul, GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoNewNameOverridesOld) {
|
| - FieldTrialFlags flags;
|
| -
|
| - EXPECT_EQ(9999ul, GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
|
| - "Group77 foo:6"));
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("InstantExtended",
|
| - "Group78 foo:5"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(1ul, flags.size());
|
| - EXPECT_EQ(6ul, GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoLotsOfFlags) {
|
| - FieldTrialFlags flags;
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
|
| - "EmbeddedSearch", "Group77 bar:1 baz:7 cat:dogs"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(3ul, flags.size());
|
| - EXPECT_EQ(true, GetBoolValueForFlagWithDefault("bar", false, flags));
|
| - EXPECT_EQ(7ul, GetUInt64ValueForFlagWithDefault("baz", 0, flags));
|
| - EXPECT_EQ("dogs",
|
| - GetStringValueForFlagWithDefault("cat", std::string(), flags));
|
| - EXPECT_EQ("default",
|
| - GetStringValueForFlagWithDefault("moose", "default", flags));
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoDisabled) {
|
| - FieldTrialFlags flags;
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
|
| - "EmbeddedSearch", "Group77 bar:1 baz:7 cat:dogs DISABLED"));
|
| - EXPECT_FALSE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(0ul, flags.size());
|
| -}
|
| -
|
| -TEST_F(EmbeddedSearchFieldTrialTest, GetFieldTrialInfoControlFlags) {
|
| - FieldTrialFlags flags;
|
| -
|
| - ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
|
| - "EmbeddedSearch", "Control77 bar:1 baz:7 cat:dogs"));
|
| - EXPECT_TRUE(GetFieldTrialInfo(&flags));
|
| - EXPECT_EQ(3ul, flags.size());
|
| -}
|
| -
|
| class SearchTest : public BrowserWithTestWindowTest {
|
| protected:
|
| virtual void SetUp() OVERRIDE {
|
|
|