Moves some functions in search.h to components.

Moves some functions in search.h to components.

These functions are simplistic and doesn't depend on chrome's
feature, so there's no reason to be under chrome/browser.
Moving to components/ would help further componentization
task of autocomplete anad omnibox_field_trials.

BUG=371538
R=brettw@chromium.org, pkasting@chromium.org, blundell@chromium.org
TBR=tedchoc@chromium.org, jhawkins@chromium.org
TEST=build

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284885

[Peter Kasting, 2014-07-16 00:40:01]

RSLGTM

[blundell, 2014-07-16 08:58:30]

//components LGTM.

All the files under //components/search should be in the "search" namespace now,
but I'm OK with doing that in followup work if you'd like.

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
components/components_tests.gyp:457: ['include', '^search_engines/'],
Please add search/ here.

https://codereview.chromium.org/393173002/diff/20001/components/search/search.h
File components/search/search.h (right):

https://codereview.chromium.org/393173002/diff/20001/components/search/search...
components/search/search.h:15: namespace chrome {
This should be in the "search" namespace now. I'm OK with doing that in a
followup if you don't want to introduce more churn in this CL.

[brettw, 2014-07-16 18:10:23]

BUILD.gn files LGTM

https://codereview.chromium.org/393173002/diff/20001/components/components.gyp
File components/components.gyp (right):

https://codereview.chromium.org/393173002/diff/20001/components/components.gy...
components/components.gyp:47: 'search.gypi',
Did you forget to git add this file?

[Jun Mukai, 2014-07-16 20:00:09]

Brett, I added you to the reviewers because you're an owner of
chrome/browser/search, not only for BUILD.gn :)

https://codereview.chromium.org/393173002/diff/20001/components/components.gyp
File components/components.gyp (right):

https://codereview.chromium.org/393173002/diff/20001/components/components.gy...
components/components.gyp:47: 'search.gypi',
On 2014/07/16 18:10:23, brettw wrote:
> Did you forget to git add this file?

good catch. added. thanks!

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
components/components_tests.gyp:457: ['include', '^search_engines/'],
On 2014/07/16 08:58:30, blundell wrote:
> Please add search/ here.

Hmm, the function I moved considers OS_IOS, does it have to be excluded?

https://codereview.chromium.org/393173002/diff/20001/components/search/search.h
File components/search/search.h (right):

https://codereview.chromium.org/393173002/diff/20001/components/search/search...
components/search/search.h:15: namespace chrome {
On 2014/07/16 08:58:30, blundell wrote:
> This should be in the "search" namespace now. I'm OK with doing that in a
> followup if you don't want to introduce more churn in this CL.

let me do that in another CL.

[Jun Mukai, 2014-07-17 17:17:07]

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
components/components_tests.gyp:457: ['include', '^search_engines/'],
On 2014/07/16 20:00:09, Jun Mukai wrote:
> On 2014/07/16 08:58:30, blundell wrote:
> > Please add search/ here.
> 
> Hmm, the function I moved considers OS_IOS, does it have to be excluded?

blundell, could you answer my question?

[Jun Mukai, 2014-07-18 16:48:29]

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
File components/components_tests.gyp (right):

https://codereview.chromium.org/393173002/diff/20001/components/components_te...
components/components_tests.gyp:457: ['include', '^search_engines/'],
On 2014/07/17 17:17:06, Jun Mukai wrote:
> On 2014/07/16 20:00:09, Jun Mukai wrote:
> > On 2014/07/16 08:58:30, blundell wrote:
> > > Please add search/ here.
> > 
> > Hmm, the function I moved considers OS_IOS, does it have to be excluded?
> 
> blundell, could you answer my question?

seems my response was based on a weird misunderstanding. Done.

[Jun Mukai, 2014-07-18 16:48:35]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-18 16:49:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/393173002/80001

[commit-bot: I haz the power, 2014-07-18 20:11:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30476)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/34887)

[commit-bot: I haz the power, 2014-07-18 20:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 20:16:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Jun Mukai, 2014-07-18 23:41:17]

adding suggested OWNERS as TBR= for the mechanical change of the following
files:
jhawkins: chrome/browser/BUILD.gn and chrome/browser/DEPS,
chrome/browser/thumbnails
tedchoc: chrome/browser/android/omnibox/...

[Jun Mukai, 2014-07-18 23:41:22]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:43:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/393173002/100001

[James Hawkins, 2014-07-18 23:47:01]

Please just ping me over chat if I miss your CL next time.

LGTM

[Jun Mukai, 2014-07-19 00:00:18]

On 2014/07/18 23:47:01, James Hawkins wrote:
> Please just ping me over chat if I miss your CL next time.
> 
> LGTM

Thanks.

By the way, if *gypi is allowed to edit by everyone, so the rule should be
applied to BUILD.gn?
I'm just wondering...

[commit-bot: I haz the power, 2014-07-19 03:05:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-19 03:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-19 03:21:05]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[Jun Mukai, 2014-07-22 00:01:33]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-22 00:02:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/393173002/120001

[Jun Mukai, 2014-07-22 01:00:38]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-22 01:01:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/393173002/140001

[commit-bot: I haz the power, 2014-07-22 03:18:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-22 03:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 03:27:43]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Jun Mukai, 2014-07-22 06:24:59]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-22 06:25:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/393173002/160001

[commit-bot: I haz the power, 2014-07-22 09:36:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-22 09:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 09:44:07]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Jun Mukai, 2014-07-23 03:33:56]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-23 03:35:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/393173002/180001

[commit-bot: I haz the power, 2014-07-23 07:03:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-23 08:48:47]

Change committed as 284885