Issue 39316: It doesn't look like initialize() is getting called properly, since webKitCli...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39316: It doesn't look like initialize() is getting called properly, since webKitCli... (Closed)

Created:
11 years, 9 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

It doesn't look like initialize() is getting called properly, since webKitClient() was NULL causing crash in the following UI tests. LayoutPluginTester.UnloadNoCrash NPAPITester.NPObjectProxy NPAPITester.SelfDeletePluginGetUrl NPAPITester.SelfDeletePluginInvoke NPAPIVisiblePluginTester.SelfDeletePluginInNewStream NPAPIVisiblePluginTester.VerifyNPObjectLifetimeTest NPAPIVisiblePluginTester.SelfDeletePluginInNPNEvaluate The correct fix is to make sure a webkit client gets set... This is a nasty hack to simply avoid the crash. TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11214

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/WebKit/chromium/src/ChromiumBridge.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

11 years, 9 months ago (2009-03-08 02:29:05 UTC) #2

TODO covered by: http://code.google.com/p/chromium/issues/detail?id=8518

Expand Messages | Collapse Messages