Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2186)

Unified Diff: Source/modules/webaudio/AudioSummingJunction.h

Issue 393133003: Oilpan: WebAudio: Apply the weak HashMap pattern to remove an entry from AudioContext::m_dirtyAudio… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a comment, etc. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/AudioSummingJunction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioSummingJunction.h
diff --git a/Source/modules/webaudio/AudioSummingJunction.h b/Source/modules/webaudio/AudioSummingJunction.h
index 263558569ff315a2b4cd478f560532ab38e878f5..b6a25be10629c5469437e4865e63792d98fa4d5b 100644
--- a/Source/modules/webaudio/AudioSummingJunction.h
+++ b/Source/modules/webaudio/AudioSummingJunction.h
@@ -63,16 +63,7 @@ public:
protected:
explicit AudioSummingJunction(AudioContext*);
- // Oilpan: m_context can be null only in the destructor because
- // AudioSummingJunction objects are owned by AudioNodes, and AudioNodes have
- // strong references to AudioContext.
- // Theorically this should be a strong reference and AudioContext::
- // m_dirtySummingJunctions should be HeapHashSet<WeakMember<
- // AudioSummingJunction>>, but we can't do them because the map is modified
- // in an audio rendering thread, which has no GC support. We need to remove
- // an AudioSummingJunction from AudioContext in ~AudioSummingJunction, and
- // this WeakMember<> makes it possible though we can't do it with Member<>.
- RefPtrWillBeWeakMember<AudioContext> m_context;
+ RefPtrWillBeMember<AudioContext> m_context;
// m_outputs contains the AudioNodeOutputs representing current connections which are not disabled.
// The rendering code should never use this directly, but instead uses m_renderingOutputs.
« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/AudioSummingJunction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698