Migrate HostZoomMap to live in StoragePartition.

content/browser/download/download_manager_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 10 matching lines @@
 #include "content/browser/download/download_item_factory.h"
 #include "content/browser/download/download_item_impl.h"
 #include "content/browser/download/download_item_impl_delegate.h"
 #include "content/browser/download/download_manager_impl.h"
 #include "content/browser/download/download_request_handle.h"
 #include "content/browser/download/mock_download_file.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager_delegate.h"
+#include "content/public/browser/zoom_level_delegate.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/test_browser_context.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/base/net_log.h"
 #include "net/base/net_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gmock_mutant.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::AllOf;
 using ::testing::DoAll;
 using ::testing::Eq;
 using ::testing::Ref;
 using ::testing::Return;
 using ::testing::ReturnRef;
 using ::testing::SetArgPointee;
 using ::testing::StrictMock;
 using ::testing::_;
 
 ACTION_TEMPLATE(RunCallback,
                 HAS_1_TEMPLATE_PARAMS(int, k),
                 AND_1_VALUE_PARAMS(p0)) {
   return ::std::tr1::get<k>(args).Run(p0);
 }
 
+// Create a specialization so we can mock an override for

[Charlie Reis, 2014/11/11 05:29:22]

This looks questionable to me, but it's well beyond my knowledge.  Is it
necessary for the mock framework?

[wjmaclean, 2014/11/11 19:20:52]

It seems to be necessary.

I think the main issue here is that gmock cannot instantiate ZoomLevelDelegate
directly in order to try and create the desired return value.

The mock function complains if you try to override a function and change its
return type (i.e. ask the mock to return a scoped_ptr to a local implementation
of ZoomLevelDelegate), and this was the only way I could find to get it to
return a null scoped_ptr<ZoomLevelDelegate>. Nicely enough, to get a non-null
value in this framework, one can implement MockZoomLevelDelegate and have the
specialization instantiate it for you, so it's extensible.

If there's a better way, I'm happy to learn how to do it. :-)

+// scoped_ptr<content::ZoomLevelDelegate>
+// BrowserContext::CreateZoomLevelDelegate(const base::FilePath&).
+template<>
+class scoped_ptr<content::ZoomLevelDelegate> {
+ public:
+  scoped_ptr() {}
+  ~scoped_ptr() {}
+};
+
 namespace content {
 class ByteStreamReader;
 
 namespace {
 
 // Matches a DownloadCreateInfo* that points to the same object as |info| and
 // has a |default_download_directory| that matches |download_directory|.
 MATCHER_P2(DownloadCreateInfoWithDefaultPath, info, download_directory, "") {
   return arg == info &&
       arg->default_download_directory == download_directory;
@@ skipping 328 matching lines @@
                           stream.get(), bound_net_log, observer);
   }
 };
 
 class MockBrowserContext : public BrowserContext {
  public:
   MockBrowserContext() {}
   ~MockBrowserContext() {}
 
   MOCK_CONST_METHOD0(GetPath, base::FilePath());
+  MOCK_METHOD1(CreateZoomLevelDelegate,
+               scoped_ptr<ZoomLevelDelegate>(const base::FilePath&));
   MOCK_CONST_METHOD0(IsOffTheRecord, bool());
   MOCK_METHOD0(GetRequestContext, net::URLRequestContextGetter*());
   MOCK_METHOD1(GetRequestContextForRenderProcess,
                net::URLRequestContextGetter*(int renderer_child_id));
   MOCK_METHOD0(GetMediaRequestContext,
                net::URLRequestContextGetter*());
   MOCK_METHOD1(GetMediaRequestContextForRenderProcess,
                net::URLRequestContextGetter*(int renderer_child_id));
   MOCK_METHOD2(GetMediaRequestContextForStoragePartition,
                net::URLRequestContextGetter*(
@@ skipping 266 matching lines @@
       .WillOnce(Return());
   EXPECT_CALL(GetMockDownloadItem(3), Remove())
       .Times(0);
 
   download_manager_->RemoveAllDownloads();
   // Because we're mocking the download item, the Remove call doesn't
   // result in them being removed from the DownloadManager list.
 }
 
 }  // namespace content