Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/profiles/host_zoom_map_browsertest.cc

Issue 393133002: Migrate HostZoomMap to live in StoragePartition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to 291677. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/host_zoom_map.h" 5 #include "content/public/browser/host_zoom_map.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/file_util.h" 12 #include "base/file_util.h"
13 #include "base/files/file_path.h" 13 #include "base/files/file_path.h"
14 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
15 #include "base/memory/scoped_ptr.h" 15 #include "base/memory/scoped_ptr.h"
16 #include "base/path_service.h" 16 #include "base/path_service.h"
17 #include "base/prefs/pref_service.h" 17 #include "base/prefs/pref_service.h"
18 #include "base/strings/stringprintf.h" 18 #include "base/strings/stringprintf.h"
19 #include "base/values.h" 19 #include "base/values.h"
20 #include "chrome/browser/chrome_page_zoom.h" 20 #include "chrome/browser/chrome_page_zoom.h"
21 #include "chrome/browser/profiles/profile.h" 21 #include "chrome/browser/profiles/profile.h"
22 #include "chrome/browser/ui/browser.h" 22 #include "chrome/browser/ui/browser.h"
23 #include "chrome/browser/ui/tabs/tab_strip_model.h" 23 #include "chrome/browser/ui/tabs/tab_strip_model.h"
24 #include "chrome/common/chrome_constants.h" 24 #include "chrome/common/chrome_constants.h"
25 #include "chrome/common/chrome_paths.h" 25 #include "chrome/common/chrome_paths.h"
26 #include "chrome/common/pref_names.h" 26 #include "chrome/common/pref_names.h"
27 #include "chrome/test/base/in_process_browser_test.h" 27 #include "chrome/test/base/in_process_browser_test.h"
28 #include "chrome/test/base/testing_profile.h" 28 #include "chrome/test/base/testing_profile.h"
29 #include "chrome/test/base/ui_test_utils.h" 29 #include "chrome/test/base/ui_test_utils.h"
30 #include "content/public/browser/browser_context.h"
31 #include "content/public/browser/storage_partition.h"
30 #include "content/public/test/test_utils.h" 32 #include "content/public/test/test_utils.h"
31 #include "net/dns/mock_host_resolver.h" 33 #include "net/dns/mock_host_resolver.h"
32 #include "net/test/embedded_test_server/embedded_test_server.h" 34 #include "net/test/embedded_test_server/embedded_test_server.h"
33 #include "net/test/embedded_test_server/http_response.h" 35 #include "net/test/embedded_test_server/http_response.h"
34 #include "testing/gmock/include/gmock/gmock.h" 36 #include "testing/gmock/include/gmock/gmock.h"
35 #include "url/gurl.h" 37 #include "url/gurl.h"
36 38
37 namespace { 39 namespace {
38 40
39 class ZoomLevelChangeObserver { 41 class ZoomLevelChangeObserver {
40 public: 42 public:
41 explicit ZoomLevelChangeObserver(Profile* profile) 43 explicit ZoomLevelChangeObserver(Profile* profile)
42 : message_loop_runner_(new content::MessageLoopRunner) { 44 : message_loop_runner_(new content::MessageLoopRunner) {
43 content::HostZoomMap* host_zoom_map = static_cast<content::HostZoomMap*>( 45 content::HostZoomMap* host_zoom_map = static_cast<content::HostZoomMap*>(
44 content::HostZoomMap::GetForBrowserContext(profile)); 46 content::HostZoomMap::GetDefaultForBrowserContext(profile));
45 subscription_ = host_zoom_map->AddZoomLevelChangedCallback(base::Bind( 47 subscription_ = host_zoom_map->AddZoomLevelChangedCallback(base::Bind(
46 &ZoomLevelChangeObserver::OnZoomLevelChanged, base::Unretained(this))); 48 &ZoomLevelChangeObserver::OnZoomLevelChanged, base::Unretained(this)));
47 } 49 }
48 50
49 void BlockUntilZoomLevelForHostHasChanged(const std::string& host) { 51 void BlockUntilZoomLevelForHostHasChanged(const std::string& host) {
50 while (!std::count(changed_hosts_.begin(), changed_hosts_.end(), host)) { 52 while (!std::count(changed_hosts_.begin(), changed_hosts_.end(), host)) {
51 message_loop_runner_->Run(); 53 message_loop_runner_->Run();
52 message_loop_runner_ = new content::MessageLoopRunner; 54 message_loop_runner_ = new content::MessageLoopRunner;
53 } 55 }
54 changed_hosts_.clear(); 56 changed_hosts_.clear();
(...skipping 13 matching lines...) Expand all
68 }; 70 };
69 71
70 } // namespace 72 } // namespace
71 73
72 class HostZoomMapBrowserTest : public InProcessBrowserTest { 74 class HostZoomMapBrowserTest : public InProcessBrowserTest {
73 public: 75 public:
74 HostZoomMapBrowserTest() {} 76 HostZoomMapBrowserTest() {}
75 77
76 protected: 78 protected:
77 void SetDefaultZoomLevel(double level) { 79 void SetDefaultZoomLevel(double level) {
78 browser()->profile()->GetPrefs()->SetDouble( 80 content::BrowserContext::GetDefaultStoragePartition(browser()->profile())
79 prefs::kDefaultZoomLevel, level); 81 ->GetZoomLevelPrefs()
82 ->SetDouble(prefs::kDefaultZoomLevel, level);
80 } 83 }
81 84
82 double GetZoomLevel(const GURL& url) { 85 double GetZoomLevel(const GURL& url) {
83 content::HostZoomMap* host_zoom_map = static_cast<content::HostZoomMap*>( 86 content::HostZoomMap* host_zoom_map = static_cast<content::HostZoomMap*>(
84 content::HostZoomMap::GetForBrowserContext(browser()->profile())); 87 content::HostZoomMap::GetDefaultForBrowserContext(
88 browser()->profile()));
85 return host_zoom_map->GetZoomLevelForHostAndScheme(url.scheme(), 89 return host_zoom_map->GetZoomLevelForHostAndScheme(url.scheme(),
86 url.host()); 90 url.host());
87 } 91 }
88 92
89 std::vector<std::string> GetHostsWithZoomLevels() { 93 std::vector<std::string> GetHostsWithZoomLevels() {
90 typedef content::HostZoomMap::ZoomLevelVector ZoomLevelVector; 94 typedef content::HostZoomMap::ZoomLevelVector ZoomLevelVector;
91 content::HostZoomMap* host_zoom_map = static_cast<content::HostZoomMap*>( 95 content::HostZoomMap* host_zoom_map = static_cast<content::HostZoomMap*>(
92 content::HostZoomMap::GetForBrowserContext(browser()->profile())); 96 content::HostZoomMap::GetDefaultForBrowserContext(
97 browser()->profile()));
93 content::HostZoomMap::ZoomLevelVector zoom_levels = 98 content::HostZoomMap::ZoomLevelVector zoom_levels =
94 host_zoom_map->GetAllZoomLevels(); 99 host_zoom_map->GetAllZoomLevels();
95 std::vector<std::string> results; 100 std::vector<std::string> results;
96 for (ZoomLevelVector::const_iterator it = zoom_levels.begin(); 101 for (ZoomLevelVector::const_iterator it = zoom_levels.begin();
97 it != zoom_levels.end(); ++it) 102 it != zoom_levels.end(); ++it)
98 results.push_back(it->host); 103 results.push_back(it->host);
99 return results; 104 return results;
100 } 105 }
101 106
102 std::vector<std::string> GetHostsWithZoomLevelsFromPrefs() { 107 std::vector<std::string> GetHostsWithZoomLevelsFromPrefs() {
103 PrefService* prefs = browser()->profile()->GetPrefs(); 108 PrefService* prefs = content::BrowserContext::GetDefaultStoragePartition(
109 browser()->profile())->GetZoomLevelPrefs();
104 const base::DictionaryValue* values = 110 const base::DictionaryValue* values =
105 prefs->GetDictionary(prefs::kPerHostZoomLevels); 111 prefs->GetDictionary(prefs::kPerHostZoomLevels);
106 std::vector<std::string> results; 112 std::vector<std::string> results;
107 if (values) { 113 if (values) {
108 for (base::DictionaryValue::Iterator it(*values); 114 for (base::DictionaryValue::Iterator it(*values);
109 !it.IsAtEnd(); it.Advance()) 115 !it.IsAtEnd(); it.Advance())
110 results.push_back(it.key()); 116 results.push_back(it.key());
111 } 117 }
112 return results; 118 return results;
113 } 119 }
(...skipping 26 matching lines...) Expand all
140 HostZoomMapSanitizationBrowserTest() {} 146 HostZoomMapSanitizationBrowserTest() {}
141 147
142 private: 148 private:
143 // InProcessBrowserTest: 149 // InProcessBrowserTest:
144 virtual bool SetUpUserDataDirectory() OVERRIDE { 150 virtual bool SetUpUserDataDirectory() OVERRIDE {
145 // Zoom-related preferences demonstrating the two problems that could be 151 // Zoom-related preferences demonstrating the two problems that could be
146 // caused by the bug. They incorrectly contain a per-host zoom level for the 152 // caused by the bug. They incorrectly contain a per-host zoom level for the
147 // empty host; and a value for 'host1' that only differs from the default by 153 // empty host; and a value for 'host1' that only differs from the default by
148 // epsilon. Neither should have been persisted. 154 // epsilon. Neither should have been persisted.
149 const char kBrokenPrefs[] = 155 const char kBrokenPrefs[] =
150 "{'profile': {" 156 "{'partition': {"
151 " 'default_zoom_level': 1.2," 157 " 'default_zoom_level': 1.2,"
152 " 'per_host_zoom_levels': {'': 1.1, 'host1': 1.20001, 'host2': 1.3}" 158 " 'per_host_zoom_levels': {'': 1.1, 'host1': 1.20001, 'host2': 1.3}"
153 "}}"; 159 "}}";
154 std::string broken_prefs(kBrokenPrefs); 160 std::string broken_prefs(kBrokenPrefs);
155 std::replace(broken_prefs.begin(), broken_prefs.end(), '\'', '\"'); 161 std::replace(broken_prefs.begin(), broken_prefs.end(), '\'', '\"');
156 162
157 base::FilePath user_data_directory, path_to_prefs; 163 base::FilePath user_data_directory, path_to_broken_prefs;
158 PathService::Get(chrome::DIR_USER_DATA, &user_data_directory); 164 PathService::Get(chrome::DIR_USER_DATA, &user_data_directory);
159 path_to_prefs = user_data_directory 165 path_to_broken_prefs = user_data_directory
160 .AppendASCII(TestingProfile::kTestUserProfileDir) 166 .AppendASCII(TestingProfile::kTestUserProfileDir)
161 .Append(chrome::kPreferencesFilename); 167 .Append(chrome::kZoomLevelPreferencesFilename);
162 base::CreateDirectory(path_to_prefs.DirName()); 168 base::CreateDirectory(path_to_broken_prefs.DirName());
163 base::WriteFile(path_to_prefs, broken_prefs.c_str(), broken_prefs.size()); 169 base::WriteFile(
170 path_to_broken_prefs, broken_prefs.c_str(), broken_prefs.size());
164 return true; 171 return true;
165 } 172 }
166 173
167 DISALLOW_COPY_AND_ASSIGN(HostZoomMapSanitizationBrowserTest); 174 DISALLOW_COPY_AND_ASSIGN(HostZoomMapSanitizationBrowserTest);
168 }; 175 };
169 176
170 // Regression test for crbug.com/364399. 177 // Regression test for crbug.com/364399.
171 IN_PROC_BROWSER_TEST_F(HostZoomMapBrowserTest, ToggleDefaultZoomLevel) { 178 IN_PROC_BROWSER_TEST_F(HostZoomMapBrowserTest, ToggleDefaultZoomLevel) {
172 const double default_zoom_level = content::ZoomFactorToZoomLevel(1.5); 179 const double default_zoom_level = content::ZoomFactorToZoomLevel(1.5);
173 180
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 // any per-host values saved either to Pref, or internally in HostZoomMap. 214 // any per-host values saved either to Pref, or internally in HostZoomMap.
208 EXPECT_TRUE(GetHostsWithZoomLevels().empty()); 215 EXPECT_TRUE(GetHostsWithZoomLevels().empty());
209 EXPECT_TRUE(GetHostsWithZoomLevelsFromPrefs().empty()); 216 EXPECT_TRUE(GetHostsWithZoomLevelsFromPrefs().empty());
210 } 217 }
211 218
212 // Test that garbage data from crbug.com/364399 is cleared up on startup. 219 // Test that garbage data from crbug.com/364399 is cleared up on startup.
213 IN_PROC_BROWSER_TEST_F(HostZoomMapSanitizationBrowserTest, ClearOnStartup) { 220 IN_PROC_BROWSER_TEST_F(HostZoomMapSanitizationBrowserTest, ClearOnStartup) {
214 EXPECT_THAT(GetHostsWithZoomLevels(), testing::ElementsAre("host2")); 221 EXPECT_THAT(GetHostsWithZoomLevels(), testing::ElementsAre("host2"));
215 EXPECT_THAT(GetHostsWithZoomLevelsFromPrefs(), testing::ElementsAre("host2")); 222 EXPECT_THAT(GetHostsWithZoomLevelsFromPrefs(), testing::ElementsAre("host2"));
216 } 223 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698