Fix a crash in PasswordManagerExceptionsView

chrome/browser/views/password_manager_view.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_VIEW_H__
 #define CHROME_BROWSER_PASSWORD_MANAGER_VIEW_H__
 
 #include <vector>
 
 #include "base/scoped_ptr.h"
 #include "chrome/browser/webdata/web_data_service.h"
 #include "chrome/common/stl_util-inl.h"
 #include "chrome/common/gfx/text_elider.h"
 #include "chrome/views/dialog_delegate.h"
 #include "chrome/views/label.h"
 #include "chrome/views/native_button.h"
 #include "chrome/views/table_view.h"
 #include "chrome/views/window.h"
 #include "webkit/glue/password_form.h"
 
 class Profile;
 
+// An observer interface to notify change of row count in a table model. This
+// allow the container view of TableView(i.e. PasswordManagerView and
+// PasswordManagerExceptionsView), to be notified of row count changes directly
+// from the TableModel. We have two different observers in
+// PasswordManagerTableModel, namely views::TableModelObserver and
+// PasswordManagerTableModelObserver, rather than adding this event to
+// views::TableModelObserver because only container view of
+// PasswordManagerTableModel cares about this event. Because of the same reason
+// the relationship between a PasswordManagerTableModel and
+// PasswordManagerTableModelObserver is 1-to-1.
+class PasswordManagerTableModelObserver {
+ public:
+  virtual void OnRowCountChanged(size_t rows) = 0;
+};
+
 class PasswordManagerTableModel : public views::TableModel,
                                   public WebDataServiceConsumer {
  public:
   explicit PasswordManagerTableModel(Profile* profile);
   virtual ~PasswordManagerTableModel();
 
   // TableModel methods.
   virtual int RowCount();
   virtual std::wstring GetText(int row, int column);
   virtual int CompareValues(int row1, int row2, int column_id);
   virtual void SetObserver(views::TableModelObserver* observer);
 
   // Delete the PasswordForm at specified row from the database (and remove
   // from view).
   void ForgetAndRemoveSignon(int row);
 
   // Delete all saved signons for the active profile (via web data service),
   // and clear the view.
   void ForgetAndRemoveAllSignons();
 
   // WebDataServiceConsumer implementation.
   virtual void OnWebDataServiceRequestDone(WebDataService::Handle h,
                                            const WDTypedResult* result);
   // Request saved logins data.
   void GetAllSavedLoginsForProfile();
 
   // Return the PasswordForm at the specified index.
   PasswordForm* GetPasswordFormAt(int row);
 
+  // Set the observer who concerns about how many rows are in the table.
+  void set_row_count_observer(PasswordManagerTableModelObserver* observer) {
+    row_count_observer_ = observer;
+  }
+
  protected:
   // Wraps the PasswordForm from the database and caches the display URL for
   // quick sorting.
   struct PasswordRow {
     PasswordRow(const gfx::SortedDisplayURL& url, PasswordForm* password_form)
         : display_url(url), form(password_form) {
     }
 
     // Contains the URL that is displayed along with the
     gfx::SortedDisplayURL display_url;
 
     // The underlying PasswordForm. We own this.
     scoped_ptr<PasswordForm> form;
   };
 
   // The web data service associated with the currently active profile.
   WebDataService* web_data_service() {
     return profile_->GetWebDataService(Profile::EXPLICIT_ACCESS);
   }
 
   // The TableView observing this model.
   views::TableModelObserver* observer_;
 
+  // Dispatching row count events specific to this password manager table model
+  // to this observer.
+  PasswordManagerTableModelObserver* row_count_observer_;
+
   // Handle to any pending WebDataService::GetLogins query.
   WebDataService::Handle pending_login_query_;
 
   // The set of passwords we're showing.
   typedef std::vector<PasswordRow*> PasswordRows;
   PasswordRows saved_signons_;
   STLElementDeleter<PasswordRows> saved_signons_cleanup_;
 
   Profile* profile_;
 
@@ skipping 16 matching lines @@
   std::wstring label_;
   std::wstring alt_label_;
   gfx::Size pref_size_;
 
   DISALLOW_EVIL_CONSTRUCTORS(MultiLabelButtons);
 };
 
 class PasswordManagerView : public views::View,
                             public views::DialogDelegate,
                             public views::TableViewObserver,
-                            public views::NativeButton::Listener {
+                            public views::NativeButton::Listener,
+                            public PasswordManagerTableModelObserver {
  public:
   explicit PasswordManagerView(Profile* profile);
   virtual ~PasswordManagerView();
 
   // Show the PasswordManagerContentView for the given profile.
   static void Show(Profile* profile);
 
   // View methods.
   virtual void Layout();
   virtual gfx::Size GetPreferredSize();
   virtual void ViewHierarchyChanged(bool is_add, views::View* parent,
                                     views::View* child);
-  virtual void SetRemoveAllEnabled(bool enabled);
-
   // views::TableViewObserver implementation.
   virtual void OnSelectionChanged();
 
   // NativeButton::Listener implementation.
   virtual void ButtonPressed(views::NativeButton* sender);
 
   // views::DialogDelegate methods:
   virtual int GetDialogButtons() const;
   virtual bool CanResize() const;
   virtual bool CanMaximize() const;
   virtual bool IsAlwaysOnTop() const;
   virtual bool HasAlwaysOnTopMenu() const;
   virtual std::wstring GetWindowTitle() const;
   virtual void WindowClosing();
   virtual views::View* GetContentsView();
 
+  // PasswordManagerTableModelObserver implementation.
+  virtual void OnRowCountChanged(size_t rows);
+
  private:
   // Wire up buttons, the model, and the table view, and query the DB for
   // saved login data tied to the given profile.
   void Init();
 
   // Helper to configure our buttons and labels.
   void SetupButtonsAndLabels();
 
   // Helper to configure our table view.
   void SetupTable();
 
   // Components in this view.
   PasswordManagerTableModel table_model_;
   views::TableView* table_view_;
 
   // The buttons and labels.
   MultiLabelButtons show_button_;
   views::NativeButton remove_button_;
   views::NativeButton remove_all_button_;
   views::Label password_label_;
 
+  static PasswordManagerView* instance_;
+
   DISALLOW_EVIL_CONSTRUCTORS(PasswordManagerView);
 };
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_VIEW_H__