Fix a crash in PasswordManagerExceptionsView

chrome/browser/views/password_manager_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "chrome/common/l10n_util.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/views/password_manager_view.h"
 #include "chrome/browser/views/standard_layout.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/views/background.h"
 #include "chrome/views/grid_layout.h"
 #include "chrome/views/native_button.h"
 #include "grit/generated_resources.h"
 
 using views::ColumnSet;
 using views::GridLayout;
 
-// We can only have one PasswordManagerView at a time.
-static PasswordManagerView* instance_ = NULL;
+PasswordManagerView* PasswordManagerView::instance_ = NULL;
 
 static const int kDefaultWindowWidth = 530;
 static const int kDefaultWindowHeight = 240;
 
 ////////////////////////////////////////////////////////////////////////////////
 // MultiLabelButtons
 //
 MultiLabelButtons::MultiLabelButtons(const std::wstring& label,
                                      const std::wstring& alt_label)
     : NativeButton(label),
@@ skipping 16 matching lines @@
                        std::max(pref_size_.height(), alt_pref_size.height()));
   }
   return gfx::Size(pref_size_.width(), pref_size_.height());
 }
 
 
 ////////////////////////////////////////////////////////////////////
 // PasswordManagerTableModel
 PasswordManagerTableModel::PasswordManagerTableModel(Profile* profile)
     : observer_(NULL),
+      row_count_observer_(NULL),
       pending_login_query_(NULL),
       saved_signons_cleanup_(&saved_signons_),
       profile_(profile) {
   DCHECK(profile && profile->GetWebDataService(Profile::EXPLICIT_ACCESS));
 }
 
 PasswordManagerTableModel::~PasswordManagerTableModel() {
   CancelLoginsQuery();
 }
 
@@ skipping 60 matching lines @@
       static_cast<const WDResult<std::vector<PasswordForm*> >*>(result);
   std::vector<PasswordForm*> rows = r->GetValue();
   STLDeleteElements<PasswordRows>(&saved_signons_);
   saved_signons_.resize(rows.size(), NULL);
   std::wstring languages =
       profile_->GetPrefs()->GetString(prefs::kAcceptLanguages);
   for (size_t i = 0; i < rows.size(); ++i) {
     saved_signons_[i] = new PasswordRow(
         gfx::SortedDisplayURL(rows[i]->origin, languages), rows[i]);
   }
-  instance_->SetRemoveAllEnabled(RowCount() != 0);
   if (observer_)
     observer_->OnModelChanged();
+  if (row_count_observer_)
+    row_count_observer_->OnRowCountChanged(RowCount());
 }
 
 void PasswordManagerTableModel::CancelLoginsQuery() {
   if (pending_login_query_) {
     web_data_service()->CancelRequest(pending_login_query_);
     pending_login_query_ = NULL;
   }
 }
 
 PasswordForm* PasswordManagerTableModel::GetPasswordFormAt(int row) {
   DCHECK(row >= 0 && row < RowCount());
   return saved_signons_[row]->form.get();
 }
 
 void PasswordManagerTableModel::ForgetAndRemoveSignon(int row) {
   DCHECK(row >= 0 && row < RowCount());
   PasswordRows::iterator target_iter = saved_signons_.begin() + row;
   // Remove from DB, memory, and vector.
   PasswordRow* password_row = *target_iter;
   web_data_service()->RemoveLogin(*(password_row->form.get()));
   delete password_row;
   saved_signons_.erase(target_iter);
-  instance_->SetRemoveAllEnabled(RowCount() != 0);
   if (observer_)
     observer_->OnItemsRemoved(row, 1);
+  if (row_count_observer_)
+    row_count_observer_->OnRowCountChanged(RowCount());
 }
 
 void PasswordManagerTableModel::ForgetAndRemoveAllSignons() {
   PasswordRows::iterator iter = saved_signons_.begin();
   while (iter != saved_signons_.end()) {
     // Remove from DB, memory, and vector.
     PasswordRow* row = *iter;
     web_data_service()->RemoveLogin(*(row->form.get()));
     delete row;
     iter = saved_signons_.erase(iter);
   }
-  instance_->SetRemoveAllEnabled(false);
   if (observer_)
     observer_->OnModelChanged();
+  if (row_count_observer_)
+    row_count_observer_->OnRowCountChanged(RowCount());
 }
 
 //////////////////////////////////////////////////////////////////////
 // PasswordManagerView
 
 // static
 void PasswordManagerView::Show(Profile* profile) {
   DCHECK(profile);
   if (!instance_) {
     instance_ = new PasswordManagerView(profile);
@@ skipping 14 matching lines @@
           l10n_util::GetString(IDS_PASSWORD_MANAGER_VIEW_HIDE_BUTTON)),
       remove_button_(l10n_util::GetString(
           IDS_PASSWORD_MANAGER_VIEW_REMOVE_BUTTON)),
       remove_all_button_(l10n_util::GetString(
           IDS_PASSWORD_MANAGER_VIEW_REMOVE_ALL_BUTTON)),
       table_model_(profile) {
   Init();
 }
 
 void PasswordManagerView::SetupTable() {
+  // Tell the table model we are concern about how many rows it has.
+  table_model_.set_row_count_observer(this);
+
   // Creates the different columns for the table.
   // The float resize values are the result of much tinkering.
   std::vector<views::TableColumn> columns;
   columns.push_back(views::TableColumn(IDS_PASSWORD_MANAGER_VIEW_SITE_COLUMN,
                                        views::TableColumn::LEFT, -1, 0.55f));
   columns.back().sortable = true;
   columns.push_back(views::TableColumn(
       IDS_PASSWORD_MANAGER_VIEW_USERNAME_COLUMN, views::TableColumn::RIGHT,
       -1, 0.37f));
   columns.back().sortable = true;
@@ skipping 127 matching lines @@
 }
 
 bool PasswordManagerView::HasAlwaysOnTopMenu() const {
   return false;
 }
 
 std::wstring PasswordManagerView::GetWindowTitle() const {
   return l10n_util::GetString(IDS_PASSWORD_MANAGER_VIEW_TITLE);
 }
 
-void PasswordManagerView::SetRemoveAllEnabled(bool enabled) {
-  instance_->remove_all_button_.SetEnabled(enabled);
-}
-
 void PasswordManagerView::ButtonPressed(views::NativeButton* sender) {
   DCHECK(window());
   // Close will result in our destruction.
   if (sender == &remove_all_button_) {
     table_model_.ForgetAndRemoveAllSignons();
     return;
   }
 
   // The following require a selection (and only one, since table is single-
   // select only).
@@ skipping 24 matching lines @@
   table_view_->SetModel(NULL);
 
   // Clear the static instance so the next time Show() is called, a new
   // instance is created.
   instance_ = NULL;
 }
 
 views::View* PasswordManagerView::GetContentsView() {
   return this;
 }
+
+void PasswordManagerView::OnRowCountChanged(size_t rows) {
+  remove_all_button_.SetEnabled(rows > 0);
+}