Fix a crash in PasswordManagerExceptionsView

chrome/browser/views/password_manager_exceptions_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "chrome/common/l10n_util.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/views/password_manager_exceptions_view.h"
 #include "chrome/browser/views/standard_layout.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/views/background.h"
 #include "chrome/views/grid_layout.h"
 #include "chrome/views/native_button.h"
 #include "grit/generated_resources.h"
 
 using views::ColumnSet;
 using views::GridLayout;
 
 // We can only have one PasswordManagerExceptionsView at a time.
-static PasswordManagerExceptionsView* instance_ = NULL;
+PasswordManagerExceptionsView* PasswordManagerExceptionsView::instance_ = NULL;
 
 static const int kDefaultWindowWidth = 530;
 static const int kDefaultWindowHeight = 240;
 
 ////////////////////////////////////////////////////////////////////
 // PasswordManagerExceptionsTableModel
 PasswordManagerExceptionsTableModel::PasswordManagerExceptionsTableModel(
     Profile* profile) : PasswordManagerTableModel(profile) {
 }
 
@@ skipping 35 matching lines @@
   std::wstring languages =
       profile_->GetPrefs()->GetString(prefs::kAcceptLanguages);
   for (size_t i = 0; i < rows.size(); ++i) {
     if (rows[i]->blacklisted_by_user) {
       saved_signons_.push_back(new PasswordRow(
           gfx::SortedDisplayURL(rows[i]->origin, languages), rows[i]));
     }
   }
   if (observer_)
     observer_->OnModelChanged();
+  if (row_count_observer_)
+    row_count_observer_->OnRowCountChanged(RowCount());
 }
 
 //////////////////////////////////////////////////////////////////////
 // PasswordManagerExceptionsView
 
 // static
 void PasswordManagerExceptionsView::Show(Profile* profile) {
   DCHECK(profile);
   if (!instance_) {
     instance_ = new PasswordManagerExceptionsView(profile);
@@ skipping 11 matching lines @@
 PasswordManagerExceptionsView::PasswordManagerExceptionsView(Profile* profile)
     : remove_button_(l10n_util::GetString(
           IDS_PASSWORD_MANAGER_EXCEPTIONS_VIEW_REMOVE_BUTTON)),
       remove_all_button_(l10n_util::GetString(
           IDS_PASSWORD_MANAGER_EXCEPTIONS_VIEW_REMOVE_ALL_BUTTON)),
       table_model_(profile) {
   Init();
 }
 
 void PasswordManagerExceptionsView::SetupTable() {
+  // Tell the table model we are concern about how many rows it has.
+  table_model_.set_row_count_observer(this);
+
   // Creates the different columns for the table.
   // The float resize values are the result of much tinkering.
   std::vector<views::TableColumn> columns;
   columns.push_back(views::TableColumn(
       IDS_PASSWORD_MANAGER_VIEW_SITE_COLUMN,
       views::TableColumn::LEFT, -1, 0.55f));
   columns.back().sortable = true;
   table_view_ = new views::TableView(&table_model_, columns, views::TEXT_ONLY,
                                      true, true, true);
   // Make the table initially sorted by host.
@@ skipping 115 matching lines @@
   table_view_->SetModel(NULL);
 
   // Clear the static instance so the next time Show() is called, a new
   // instance is created.
   instance_ = NULL;
 }
 
 views::View* PasswordManagerExceptionsView::GetContentsView() {
   return this;
 }
+
+void PasswordManagerExceptionsView::OnRowCountChanged(size_t rows) {
+  remove_all_button_.SetEnabled(rows > 0);
+}