Source/devtools/front_end/timeline/Layers3DView.js - Issue 393123007: DevTools: Remove popover and add properties section for paint profiler log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/Layers3DView.js

Issue 393123007: DevTools: Remove popover and add properties section for paint profiler log. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed test. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/layersPanel.css ('K') | « Source/devtools/front_end/layersPanel.css ('k') | Source/devtools/front_end/timeline/PaintProfilerView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/Layers3DView.js

diff --git a/Source/devtools/front_end/timeline/Layers3DView.js b/Source/devtools/front_end/timeline/Layers3DView.js

index a6406492ca4daf02f9059dc3c87b8b8a2e954537..b6db932705d71eaa5268611301f9acbec236e61a 100644

--- a/Source/devtools/front_end/timeline/Layers3DView.js

+++ b/Source/devtools/front_end/timeline/Layers3DView.js

@@ -651,7 +651,7 @@ WebInspector.Layers3DView.prototype = {

var node = activeObject && activeObject.layer && activeObject.layer.nodeForSelfOrAncestor();

var contextMenu = new WebInspector.ContextMenu(event);

contextMenu.appendItem(WebInspector.UIString("Reset View"), this._transformController.resetAndNotify.bind(this._transformController), false);

- if (activeObject.type() === WebInspector.Layers3DView.ActiveObject.Type.Tile)

+ if (activeObject && activeObject.type() === WebInspector.Layers3DView.ActiveObject.Type.Tile)

contextMenu.appendItem(WebInspector.UIString("Jump to Paint Event"), this.dispatchEventToListeners.bind(this, WebInspector.Layers3DView.Events.JumpToPaintEventRequested, activeObject.traceEvent), false);

if (node)

contextMenu.appendApplicableItems(node);