DevTools: Remove popover and add properties section for paint profiler log.

Source/devtools/front_end/timeline/PaintProfilerView.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 /**
  * @constructor
  * @param {function(string=)} showImageCallback
  * @extends {WebInspector.HBox}
  */
 WebInspector.PaintProfilerView = function(showImageCallback)
 {
     WebInspector.HBox.call(this);
+    this.registerRequiredCSS("paintProfilerView.css");
     this.element.classList.add("paint-profiler-view");
 
     this._showImageCallback = showImageCallback;
 
     this._canvas = this.element.createChild("canvas", "fill");
     this._context = this._canvas.getContext("2d");
     this._selectionWindow = new WebInspector.OverviewGrid.Window(this.element, this.element);
     this._selectionWindow.addEventListener(WebInspector.OverviewGrid.Events.WindowChanged, this._onWindowChanged, this);
 
     this._innerBarWidth = 4 * window.devicePixelRatio;
@@ skipping 158 matching lines @@
 };
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.PaintProfilerCommandLogView = function()
 {
     WebInspector.VBox.call(this);
     this.setMinimumSize(100, 25);
-    this.element.classList.add("outline-disclosure");
+    this.element.classList.add("outline-disclosure", "profiler-log-view");
     var sidebarTreeElement = this.element.createChild("ol", "sidebar-tree");
     sidebarTreeElement.addEventListener("mousemove", this._onMouseMove.bind(this), false);
     sidebarTreeElement.addEventListener("mouseout", this._onMouseMove.bind(this), false);
     sidebarTreeElement.addEventListener("contextmenu", this._onContextMenu.bind(this), true);
     this.sidebarTree = new TreeOutline(sidebarTreeElement);
-    this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, this._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), undefined, true);
 
     this._reset();
 }
 
 WebInspector.PaintProfilerCommandLogView.prototype = {
     /**
      * @param {?WebInspector.Target} target
      * @param {!Array.<!WebInspector.PaintProfilerLogItem>=} log
      */
     setCommandLog: function(target, log)
@@ skipping 17 matching lines @@
             this.sidebarTree.appendChild(node);
         }
     },
 
     _reset: function()
     {
         this._log = [];
     },
 
     /**
-     * @param {!Element} target
-     * @return {!Element}
-     */
-    _getHoverAnchor: function(target)
-    {
-        return /** @type {!Element} */ (target.enclosingNodeOrSelfWithNodeName("span"));
-    },
-
-    /**
-     * @param {!Element} element
-     * @param {function(!WebInspector.RemoteObject, boolean, !Element=):undefined} showCallback
-     */
-    _resolveObjectForPopover: function(element, showCallback)
-    {
-        var liElement = element.enclosingNodeOrSelfWithNodeName("li");
-        var logItem = liElement.treeElement.representedObject;
-        var obj = {"method": logItem.method};
-        if (logItem.params)
-            obj.params = logItem.params;
-        showCallback(WebInspector.RemoteObject.fromLocalObject(obj), false);
-    },
-
-    /**
      * @param {?Event} event
      */
     _onMouseMove: function(event)
     {
         var node = this.sidebarTree.treeElementFromPoint(event.pageX, event.pageY);
-        if (node === this._lastHoveredNode)
+        if (node === this._lastHoveredNode || !(node instanceof WebInspector.LogTreeElement))
             return;
         if (this._lastHoveredNode)
             this._lastHoveredNode.setHovered(false);
         this._lastHoveredNode = node;
         if (this._lastHoveredNode)
             this._lastHoveredNode.setHovered(true);
     },
 
     /**
      * @param {?Event} event
      */
     _onContextMenu: function(event)
     {
         if (!this._target)
             return;
         var node = this.sidebarTree.treeElementFromPoint(event.pageX, event.pageY);
-        if (!node || !node.representedObject)
+        if (!node || !node.representedObject || !(node instanceof WebInspector.LogTreeElement))
             return;
         var logItem = /** @type {!WebInspector.PaintProfilerLogItem} */ (node.representedObject);
         if (!logItem.nodeId())
             return;
         var contextMenu = new WebInspector.ContextMenu(event);
         var domNode = new WebInspector.DeferredDOMNode(this._target, logItem.nodeId());
         contextMenu.appendApplicableItems(domNode);
         contextMenu.show();
     },
 
@@ skipping 48 matching lines @@
             str += this._paramToString(params[key], key);
         }
         return str;
     },
 
     _update: function()
     {
         var logItem = this.representedObject;
         var title = document.createDocumentFragment();
         title.createChild("div", "selection");
-        var span = title.createChild("span");
-        var textContent = logItem.method;
-        if (logItem.params)
-            textContent += "(" + this._paramsToString(logItem.params) + ")";

[caseq, 2014/07/21 14:36:41]

We still want this, so that we can have a quick overview of what the call does.

[malch, 2014/07/22 07:22:25]

Done.

-        span.textContent = textContent;
+        var section = new WebInspector.ObjectPropertiesSection(WebInspector.RemoteObject.fromLocalObject(logItem.params), logItem.method);
+        title.appendChild(section.element);
         this.title = title;
     },
 
     /**
      * @param {boolean} hovered
      */
     setHovered: function(hovered)
     {
         this.listItemElement.classList.toggle("hovered", hovered);
         var target = this._ownerView._target;
@@ skipping 113 matching lines @@
     var method = logItem.method.toTitleCase();
 
     var logItemCategories = WebInspector.PaintProfilerView._initLogItemCategories();
     var result = logItemCategories[method];
     if (!result) {
         result = WebInspector.PaintProfilerView.categories()["misc"];
         logItemCategories[method] = result;
     }
     return result;
 }