Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 393123005: Change webkit_unit_tests to use webkit_support.h. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews
Project:
blink
Visibility:
Public.

Description

Change webkit_unit_tests to use webkit_support.h. webkit_unit_test_support.h's functions are just thin wrappers that just call the functions from webkit_support.h. So instead of having this unnecessary indirection, just call the functions from webkit_support.h directly. This is a two side patch. After this lands, Chromium will be update to remove webkit_unit_test_support.* BUG=None TEST=webkit_unit_tests R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178440

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/web/tests/RunAllTests.cpp View 2 chunks +5 lines, -5 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
https://codereview.chromium.org/393123005/diff/1/Source/web/tests/RunAllTests.cpp File Source/web/tests/RunAllTests.cpp (right): https://codereview.chromium.org/393123005/diff/1/Source/web/tests/RunAllTests.cpp#newcode35 Source/web/tests/RunAllTests.cpp:35: // FIXME: Avoid this source dependency on Chromium's base ...
6 years, 5 months ago (2014-07-18 03:42:57 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/393123005/diff/1/Source/web/tests/RunAllTests.cpp File Source/web/tests/RunAllTests.cpp (right): https://codereview.chromium.org/393123005/diff/1/Source/web/tests/RunAllTests.cpp#newcode35 Source/web/tests/RunAllTests.cpp:35: // FIXME: Avoid this source dependency on Chromium's ...
6 years, 5 months ago (2014-07-18 08:59:16 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-18 13:11:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/393123005/1
6 years, 5 months ago (2014-07-18 13:12:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 13:48:14 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 14:24:52 UTC) #6
Message was sent while issue was closed.
Change committed as 178440

Powered by Google App Engine
This is Rietveld 408576698