Add warnings to inspector DOM count unittest baselines.

Add warnings to inspector DOM count unittest baselines.

The unit test failure indicates a serious Document leak, where all
WebCore::Document loaded in Chrome is leaking.
This CL adds warning comments to the baseline to avoid regressions.

BUG=392121
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284653

[kouhei (in TOK), 2014-07-18 01:57:42]

Would you take a look?

[haraken, 2014-07-18 01:59:06]

LGTM

[haraken, 2014-07-18 01:59:43]

https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py
(right):

https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py:24:
self.assertEqual(counts['event_listener_count'], 2)

Do these numbers indicate we already have leaks?

[kouhei (in TOK), 2014-07-18 02:01:20]

On 2014/07/18 01:59:43, haraken wrote:
>
https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
> File
tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py
> (right):
> 
>
https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
>
tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py:24:
> self.assertEqual(counts['event_listener_count'], 2)
> 
> Do these numbers indicate we already have leaks?

No, the current numbers exactly match the numbers on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/un...

[hajimehoshi, 2014-07-18 03:23:57]

lgtm, thanks!

[kouhei (in TOK), 2014-07-22 00:41:21]

tonyg: Would you take a look? Thanks!

[tonyg, 2014-07-22 02:41:58]

lgtm in advance

https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py
(right):

https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py:22:
self.assertEqual(counts['document_count'], 1)
Rather than a comment, I recommend adding a third arg, msg='...', which explains
what you're saying in the comment. That way it'll show up on the bots and folks
will notice it.

[kouhei (in TOK), 2014-07-22 09:06:05]

On 2014/07/22 02:41:58, tonyg wrote:
> lgtm in advance
> 
>
https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
> File
tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py
> (right):
> 
>
https://codereview.chromium.org/393123003/diff/1/tools/telemetry/telemetry/co...
>
tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py:22:
> self.assertEqual(counts['document_count'], 1)
> Rather than a comment, I recommend adding a third arg, msg='...', which
explains
> what you're saying in the comment. That way it'll show up on the bots and
folks
> will notice it.

Thanks! added.

[kouhei (in TOK), 2014-07-22 09:06:08]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-07-22 09:07:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/393123003/20001

[commit-bot: I haz the power, 2014-07-22 09:09:12]

Change committed as 284653