Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: mojo/services/public/cpp/surfaces/surfaces_type_converters.h

Issue 393103003: Update Mojo surfaces type converters to use RP for generating DQ and SQS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@publicDQ
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/cpp/surfaces/surfaces_type_converters.h
diff --git a/mojo/services/public/cpp/surfaces/surfaces_type_converters.h b/mojo/services/public/cpp/surfaces/surfaces_type_converters.h
index 89abd160d5115b572751357247da806df2a23318..8d03e7cca369af4833aa2e0b16773f9dcb531327 100644
--- a/mojo/services/public/cpp/surfaces/surfaces_type_converters.h
+++ b/mojo/services/public/cpp/surfaces/surfaces_type_converters.h
@@ -47,26 +47,21 @@ template <>
class MOJO_SURFACES_EXPORT TypeConverter<surfaces::QuadPtr, cc::DrawQuad> {
public:
static surfaces::QuadPtr ConvertFrom(const cc::DrawQuad& input);
+ // RenderPass owns allocation of DrawQuads. No need for isolated DrawQuad
+ // conversion function. Functionality is covered by RenderPass ConvertTo.
jamesr 2014/07/17 20:25:24 not sure this comment needs to be here - several c
};
-// This can't use the TypeConverter since it has to return a pointer to a type
-// since cc::DrawQuad is polymorphic and needs an additional input. The
-// TypeConverter for surfaces::Pass calls this explicitly.
-MOJO_SURFACES_EXPORT scoped_ptr<cc::DrawQuad> ConvertTo(
- const surfaces::QuadPtr& input,
- cc::SharedQuadState* sqs);
-
template <>
class MOJO_SURFACES_EXPORT
TypeConverter<surfaces::SharedQuadStatePtr, cc::SharedQuadState> {
public:
static surfaces::SharedQuadStatePtr ConvertFrom(
const cc::SharedQuadState& input);
+ // RenderPass owns allocation of SharedQuadState. No need for isolated
+ // SharedQuadState conversion function. Functionality is covered by RenderPass
+ // ConvertTo.
};
-MOJO_SURFACES_EXPORT scoped_ptr<cc::SharedQuadState> ConvertTo(
- const surfaces::SharedQuadStatePtr& input);
-
template <>
class MOJO_SURFACES_EXPORT TypeConverter<surfaces::PassPtr, cc::RenderPass> {
public:

Powered by Google App Engine
This is Rietveld 408576698