Issue 393093003: Mojo: Move sample_app out from namespace mojo

Issue 393093003: Mojo: Move sample_app out from namespace mojo (Closed)

Created:
6 years, 5 months ago by Hajime Morrita

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review), Ben Goodger (Google), viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Move sample_app out from namespace mojo The sample isn't part of mojo implementation, so it should be outside of mojo:: namespace. TEST=none BUG=330467 R=darin@chromium.org, ben@chromium.org, viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283463

Patch Set 2 : Landing #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -30 lines)			Patch
M	mojo/examples/sample_app/gles2_client_impl.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	mojo/examples/sample_app/gles2_client_impl.cc	View	1	9 chunks	+8 lines, -10 lines	0 comments	Download
M	mojo/examples/sample_app/sample_app.cc	View		5 chunks	+13 lines, -11 lines	0 comments	Download
M	mojo/examples/sample_app/spinning_cube.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	mojo/examples/sample_app/spinning_cube.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM w/nits. https://codereview.chromium.org/393093003/diff/1/mojo/examples/sample_app/gles2_client_impl.cc File mojo/examples/sample_app/gles2_client_impl.cc (right): https://codereview.chromium.org/393093003/diff/1/mojo/examples/sample_app/gles2_client_impl.cc#newcode133 mojo/examples/sample_app/gles2_client_impl.cc:133: Nit: Delete extra blank line. https://codereview.chromium.org/393093003/diff/1/mojo/examples/sample_app/spinning_cube.cc File ...

6 years, 5 months ago (2014-07-15 20:49:08 UTC) #2

Hajime Morrita

Thank you for review! Landing. https://codereview.chromium.org/393093003/diff/1/mojo/examples/sample_app/gles2_client_impl.cc File mojo/examples/sample_app/gles2_client_impl.cc (right): https://codereview.chromium.org/393093003/diff/1/mojo/examples/sample_app/gles2_client_impl.cc#newcode133 mojo/examples/sample_app/gles2_client_impl.cc:133: On 2014/07/15 20:49:08, viettrungluu ...

6 years, 5 months ago (2014-07-15 23:04:53 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/393093003/20001

6 years, 5 months ago (2014-07-15 23:07:57 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-16 07:57:10 UTC) #7

Message was sent while issue was closed.

Change committed as 283463

Expand Messages | Collapse Messages