Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 393083006: clang/win: Make winstorage:: not ambiguous. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang/win: Make winstorage:: not ambiguous. stdafx.h declared a global winstorage namespace alias, this file declared a winstorage namespace alias in an unnamed namespace. clang correctly points out that error(clang): reference to 'winstorage' is ambiguous note(clang): candidate found by name lookup is 'winstorage' note(clang): candidate found by name lookup is '(anonymous namespace)::winstorage' Just remove the unneeded duplicate. BUG=82385 TBR=ananta@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M win8/metro_driver/file_picker_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 5 months ago (2014-07-18 19:48:12 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-18 20:07:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/393083006/1
6 years, 5 months ago (2014-07-18 20:09:54 UTC) #3
commit-bot: I haz the power
Change committed as 284190
6 years, 5 months ago (2014-07-18 20:12:38 UTC) #4
ananta
6 years, 5 months ago (2014-07-18 20:23:31 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698