sync/protocol/proto_value_conversions.cc - Issue 393083004: Update Commit and GetUpdatesResponse messages to include attachment ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 393083004: Update Commit and GetUpdatesResponse messages to include attachment ids. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update SyncManagerImpl to detect attachment metadata changes. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/protocol/proto_value_conversions.cc

diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc

index 2716210a56af9a522af042cc0a9a90a581428a97..6680e797c86e79a37082395f7eeb16a3126194df 100644

--- a/sync/protocol/proto_value_conversions.cc

+++ b/sync/protocol/proto_value_conversions.cc

@@ -849,6 +849,7 @@ base::DictionaryValue* SyncEntityToValue(const sync_pb::SyncEntity& proto,

SET(specifics, EntitySpecificsToValue);

SET_BOOL(folder);

SET_STR(client_defined_unique_tag);

+ SET_REP(attachment_id, AttachmentIdProtoToValue);

return value;

}

« no previous file with comments | « sync/internal_api/test/test_entry_factory.cc ('k') | sync/syncable/model_neutral_mutable_entry.h » ('j') | no next file with comments »