sync/engine/get_commit_ids.cc - Issue 393083004: Update Commit and GetUpdatesResponse messages to include attachment ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/get_commit_ids.cc

Issue 393083004: Update Commit and GetUpdatesResponse messages to include attachment ids. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update SyncManagerImpl to detect attachment metadata changes. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/get_commit_ids.cc

diff --git a/sync/engine/get_commit_ids.cc b/sync/engine/get_commit_ids.cc

index 5f91915d5a0720e018ea333938e1329727c85cc4..5718cec711a118afe06c322bfa9f89fdfe0c8bf9 100644

--- a/sync/engine/get_commit_ids.cc

+++ b/sync/engine/get_commit_ids.cc

@@ -108,7 +108,6 @@ bool IsEntryInConflict(const syncable::Entry& entry) {

// Return true if this entry has any attachments that haven't yet been uploaded

// to the server.

bool HasAttachmentNotOnServer(const syncable::Entry& entry) {

- // TODO(maniscalco): Add test case (bug 356266).

const sync_pb::AttachmentMetadata& metadata = entry.GetAttachmentMetadata();

for (int i = 0; i < metadata.record_size(); ++i) {

if (!metadata.record(i).is_on_server()) {

« no previous file with comments | « sync/engine/directory_update_handler_unittest.cc ('k') | sync/engine/syncer_util.cc » ('j') | no next file with comments »