Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 393083003: Add env_chromium_unittests to the chromium_builder_dbg_tsan_win target. (Closed)

Created:
6 years, 5 months ago by cmumford
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add env_chromium_unittests to the chromium_builder_dbg_tsan_win target. This one change should have been part of an earlier CL (r274947). BUG=326304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cmumford
This change is to ensure the env_chromium_unittests are built so that I can land crrev.com/199413004. ...
6 years, 5 months ago (2014-07-15 20:27:08 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-16 16:55:14 UTC) #2
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-16 17:02:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/393083003/1
6 years, 5 months ago (2014-07-16 17:03:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 21:24:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 02:03:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39669)
6 years, 5 months ago (2014-07-17 02:03:04 UTC) #7
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-17 18:19:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/393083003/1
6 years, 5 months ago (2014-07-17 18:21:28 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:31:18 UTC) #10
Message was sent while issue was closed.
Change committed as 283857

Powered by Google App Engine
This is Rietveld 408576698