Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Issue 393073002: Cleanup list of source files in remoting targets (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
weitao, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup list of source files in remoting targets Some files were compiled for both remoting_host and remoting_core. Also moved some files to remoting_host so that they don't need to be listed multiple times for different platforms Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283597

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M remoting/host/host_main.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.h View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/remoting_host.gypi View 1 2 3 4 5 4 chunks +3 lines, -3 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-15 19:31:37 UTC) #1
weitao
On 2014/07/15 19:31:37, Sergey Ulanov wrote: LGTM
6 years, 5 months ago (2014-07-15 20:20:58 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-15 20:24:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393073002/20001
6 years, 5 months ago (2014-07-15 20:27:07 UTC) #4
Sergey Ulanov
The CQ bit was unchecked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 00:07:28 UTC) #5
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 00:07:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393073002/40001
6 years, 5 months ago (2014-07-16 00:12:18 UTC) #7
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 00:44:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393073002/60001
6 years, 5 months ago (2014-07-16 00:49:35 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 09:02:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 09:10:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/38437)
6 years, 5 months ago (2014-07-16 09:10:10 UTC) #12
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 19:51:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393073002/100001
6 years, 5 months ago (2014-07-16 19:54:52 UTC) #14
Sergey Ulanov
6 years, 5 months ago (2014-07-17 01:03:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #6 manually as r283597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698