Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 39307: Fix memory leak of "screen size bitmap" (e.g. 1.5M if 750x548) ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
7 years, 11 months ago by John Grabowski
5 years, 8 months ago


Fix memory leak of "screen size bitmap" (e.g. 1.5M if 750x548) that happened on *every page view* on OSX. VSIZE/RSIZE now hovers around 500M/30M instead of growing to 1.3G/260M within a few minutes. Surprisingly, seems quite a bit snappier! The essence of the change is that SkBitmap::setPixels() does NOT take ownership of the pointer, whereas SkBitmap::allocPixels() both allocates and owns. Committed:

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M skia/ext/ View 2 chunks +4 lines, -5 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 2 (0 generated)
John Grabowski
7 years, 11 months ago (2009-03-07 03:29:08 UTC) #1
7 years, 11 months ago (2009-03-09 14:19:08 UTC) #2
Awesome! LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd