Issue 393033009: roll gyp 1951:1953

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 393033009: roll gyp 1951:1953 (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

roll gyp 1951:1953 1952: Add test files for https://codereview.chromium.org/406523005/ 1953: ninja/win: Put common msvs_system_include_dirs into %INCLUDE% BUG=395405 R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284370

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/393033009/1

6 years, 5 months ago (2014-07-20 16:20:04 UTC) #5

Nico

Committed patchset #1 manually as r284370 (tree was closed).

6 years, 5 months ago (2014-07-20 17:28:21 UTC) #7

Nico

6 years, 5 months ago (2014-07-20 17:28:59 UTC) #8

Message was sent while issue was closed.

On 2014/07/20 17:28:21, Nico (away) wrote:
> Committed patchset #1 manually as r284370 (tree was closed).

(in part to check if the content_tests failure on the android bot will stay
around for another round; in that case the v8 roll probably needs to be
reverted.)

Expand Messages | Collapse Messages