chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 393033006: Added tab notification to accessibility_event_router_views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 393033006: Added tab notification to accessibility_event_router_views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: GetTabCount returns 1 in test class Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc ('K') | « chrome/browser/ui/views/ash/tab_scrubber.cc ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | chrome/browser/ui/views/tabs/tab_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index efb0ceb5929f1f8d438dfe2c0c98ea08e369b0d5..93e2d7dfc542839e065294813e70f529a5c1e698 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -312,7 +312,7 @@ void BrowserTabStripController::UpdateLoadingAnimations() {

// Don't use the model count here as it's possible for this to be invoked

// before we've applied an update from the model (Browser::TabInsertedAt may

// be processed before us and invokes this).

- for (int i = 0, tab_count = tabstrip_->tab_count(); i < tab_count; ++i) {

+ for (int i = 0, tab_count = tabstrip_->GetTabCount(); i < tab_count; ++i) {

if (model_->ContainsIndex(i)) {

Tab* tab = tabstrip_->tab_at(i);

WebContents* contents = model_->GetWebContentsAt(i);