Added tab notification to accessibility_event_router_views.

chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/accessibility/accessibility_event_router_views.h"
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 191 matching lines @@
     SendTextfieldNotification(view, type, profile);
     break;
   case ui::AX_ROLE_MENU_ITEM:
     SendMenuItemNotification(view, type, profile);
     break;
   case ui::AX_ROLE_RADIO_BUTTON:
     // Not used anymore?
   case ui::AX_ROLE_SLIDER:
     SendSliderNotification(view, type, profile);
     break;
+  case ui::AX_ROLE_TAB:
+    SendTabNotification(view, type, profile);
+    break;
   case ui::AX_ROLE_TREE:
     SendTreeNotification(view, type, profile);
     break;
   case ui::AX_ROLE_TREE_ITEM:
     SendTreeItemNotification(view, type, profile);
     break;
   default:
     // Hover events can fire on literally any view, so it's safe to
     // ignore ones we don't care about.
     if (type == ui::AX_EVENT_HOVER)
@@ skipping 57 matching lines @@
     count = 0;
     RecursiveGetMenuItemIndexAndCount(parent_menu, view, &index, &count);
   }
 
   AccessibilityMenuItemInfo info(
       profile, name, context, has_submenu, index, count);
   SendControlAccessibilityNotification(event, &info);
 }
 
 // static
+void AccessibilityEventRouterViews::SendTabNotification(
+    views::View* view,
+    ui::AXEvent event,
+    Profile* profile) {
+  ui::AXViewState state;
+  view->GetAccessibleState(&state);
+  std::string name = base::UTF16ToUTF8(state.name);
+  std::string context = GetViewContext(view);

[Peter Kasting, 2014/07/16 23:40:54]

Nit: I suggest inlining these two below to avoid temps

[evy, 2014/07/21 17:54:15]

This pattern was actually copied from another function in this file.
Would it be good to change all of the places this pattern occurs?

[Peter Kasting, 2014/07/21 19:06:07]

You can if you want.  It doesn't matter much to me either way.

+  AccessibilityTabInfo info(profile, name, context, state.index, state.count);
+  SendControlAccessibilityNotification(event, &info);
+}
+
+// static
 void AccessibilityEventRouterViews::SendTreeNotification(
     views::View* view,
     ui::AXEvent event,
     Profile* profile) {
   AccessibilityTreeInfo info(profile, GetViewName(view));
   SendControlAccessibilityNotification(event, &info);
 }
 
 // static
 void AccessibilityEventRouterViews::SendTreeItemNotification(
@@ skipping 246 matching lines @@
     return base::UTF16ToUTF8(state.name);
 
   for (int i = 0; i < view->child_count(); ++i) {
     views::View* child = view->child_at(i);
     std::string result = RecursiveGetStaticText(child);
     if (!result.empty())
       return result;
   }
   return std::string();
 }