Add settings for keyboard auto-repeat to options page.

chrome/browser/resources/options/pref_ui.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var Preferences = options.Preferences;
 
   /**
    * Allows an element to be disabled for several reasons.
@@ skipping 63 matching lines @@
      * updates the associated pref.
      * @param {Event} event Change event.
      * @private
      */
     handleChange_: function(event) {
       if (!this.customChangeHandler(event))
         this.updatePrefFromState_();
     },
 
     /**
-     * Update the input element's state when the associated pref changes.
+     * Handles changes to the pref. If a custom change handler does not suppress
+     * it, a default handler is invoked that update the input element's state.
      * @param {Event} event Pref change event.
      * @private
      */
     updateStateFromPref_: function(event) {
-      this.value = event.value.value;
+      if (!this.customPrefChangeHandler(event))
+        this.value = event.value.value;
     },
 
     /**
      * See |updateDisabledState_| above.
      */
     setDisabled: function(reason, disabled) {
       updateDisabledState_(this, reason, disabled);
     },
 
     /**
      * Custom change handler that is invoked first when the user makes changes
      * to the input element's state. If it returns false, a default handler is
      * invoked next that updates the associated pref. If it returns true, the
      * default handler is suppressed (i.e., this works like stopPropagation or
      * cancelBubble).
      * @param {Event} event Input element change event.
      */
     customChangeHandler: function(event) {
       return false;
     },
+
+    /**
+     * Custom change handler that is invoked first when the preference
+     * associated with the input element changes. If it returns false, a default
+     * handler is invoked next that updates the input element. If it returns
+     * true, the default handler is suppressed.
+     * @param {Event} event Input element change event.
+     */
+    customPrefChangeHandler: function(event) {
+      return false;
+    },
   };
 
   /**
    * The name of the associated preference.
    * @type {string}
    */
   cr.defineProperty(PrefInputElement, 'pref', cr.PropertyKind.ATTR);
 
   /**
    * The data type of the associated preference, only relevant for derived
@@ skipping 57 matching lines @@
       Preferences.setBooleanPref(this.pref, value,
                                  !this.dialogPref, this.metric);
     },
 
     /**
      * Update the checkbox state when the associated pref changes.
      * @param {Event} event Pref change event.
      * @private
      */
     updateStateFromPref_: function(event) {
-      var value = Boolean(event.value.value);
-      this.checked = this.inverted_pref ? !value : value;
+      if (!this.customPrefChangeHandler(event)) {

[stevenjb, 2014/07/22 16:42:23]

nit: Here and below, I think the logic would be a tiny bit more clear using an
early exit.

[michaelpg, 2014/07/22 17:34:54]

Done.

+        var value = Boolean(event.value.value);
+        this.checked = this.inverted_pref ? !value : value;
+      }
     },
   };
 
   /**
    * Whether the mapping between checkbox state and associated pref is inverted.
    * @type {boolean}
    */
   cr.defineProperty(PrefCheckbox, 'inverted_pref', cr.PropertyKind.BOOL_ATTR);
 
   /////////////////////////////////////////////////////////////////////////////
@@ skipping 58 matching lines @@
                                    !this.dialogPref, this.metric);
       }
     },
 
     /**
      * Update the radio button state when the associated pref changes.
      * @param {Event} event Pref change event.
      * @private
      */
     updateStateFromPref_: function(event) {
-      this.checked = this.value == String(event.value.value);
+      if (!this.customPrefChangeHandler(event))
+        this.checked = this.value == String(event.value.value);
     },
   };
 
   /////////////////////////////////////////////////////////////////////////////
   // PrefRange class:
 
   // Define a constructor that uses an input element as its underlying element.
   var PrefRange = cr.ui.define('input');
 
   PrefRange.prototype = {
@@ skipping 43 matching lines @@
      * handler is invoked that updates the associated pref.
      * @param {Event} event Change event.
      * @private
      */
     handleRelease_: function(event) {
       if (!this.customChangeHandler(event))
         this.updatePrefFromState_();
     },
 
     /**
-     * Update the slider position when the associated pref changes.
+     * Handles changes to the pref associated with the slider. If a custom
+     * change handler does not suppress it, a default handler is invoked that
+     * updates the slider position.
      * @param {Event} event Pref change event.
      * @private
      */
     updateStateFromPref_: function(event) {
-      var value = event.value.value;
-      this.value = this.valueMap ? this.valueMap.indexOf(value) : value;
+      if (!this.customPrefChangeHandler(event)) {
+        var value = event.value.value;
+        this.value = this.valueMap ? this.valueMap.indexOf(value) : value;
+      }
     },
 
     /**
      * Map slider position to the range of values provided by the client,
      * represented by |valueMap|.
      * @param {number} position The slider position to map.
      */
     mapPositionToPref: function(position) {
       return this.valueMap ? this.valueMap[position] : position;
     },
@@ skipping 37 matching lines @@
                         this.dataType);
       }
     },
 
     /**
      * Update the selected item when the associated pref changes.
      * @param {Event} event Pref change event.
      * @private
      */
     updateStateFromPref_: function(event) {
+      if (this.customPrefChangeHandler(event))
+        return;
+
       // Make sure the value is a string, because the value is stored as a
       // string in the HTMLOptionElement.
       value = String(event.value.value);
 
       var found = false;
       for (var i = 0; i < this.options.length; i++) {
         if (this.options[i].value == value) {
           this.selectedIndex = i;
           found = true;
         }
@@ skipping 148 matching lines @@
     PrefNumber: PrefNumber,
     PrefRadio: PrefRadio,
     PrefRange: PrefRange,
     PrefSelect: PrefSelect,
     PrefTextField: PrefTextField,
     PrefPortNumber: PrefPortNumber,
     PrefButton: PrefButton
   };
 
 });