chrome/browser/extensions/api/cast_channel/cast_channel_api.h - Issue 393023003: Added connection timeout functionality to CastSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cast_channel/cast_channel_api.h

Issue 393023003: Added connection timeout functionality to CastSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: JS API plumbing, switch approach from MessageLoop to Timer, better testing. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/cast_channel/cast_channel_api.cc » ('j') | chrome/browser/extensions/api/cast_channel/cast_socket_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cast_channel/cast_channel_api.h

diff --git a/chrome/browser/extensions/api/cast_channel/cast_channel_api.h b/chrome/browser/extensions/api/cast_channel/cast_channel_api.h

index 6d60de2127f2ee3dd3b99f04a8b2957d1b65681b..07e94e0df42c45299a285dbdda3d8ec157068d02 100644

--- a/chrome/browser/extensions/api/cast_channel/cast_channel_api.h

+++ b/chrome/browser/extensions/api/cast_channel/cast_channel_api.h

@@ -45,7 +45,8 @@ class CastChannelAPI : public BrowserContextKeyedAPI,

scoped_ptr<cast_channel::CastSocket> CreateCastSocket(

const std::string& extension_id,

const net::IPEndPoint& ip_endpoint,

- cast_channel::ChannelAuthType channel_auth);

+ cast_channel::ChannelAuthType channel_auth,

+ int timeout_millis);

// Sets the CastSocket instance to be returned by CreateCastSocket for

// testing.