Issue 393017: This CL fixes the document-open.html and window-open.html plugin layout tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 393017: This CL fixes the document-open.html and window-open.html plugin layout tests... (Closed)

Created:
11 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, jam, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL fixes the document-open.html and window-open.html plugin layout tests. These were landed in webkit as fixes for bug https://bugs.webkit.org/show_bug.cgi?id=31067 The layout test plugin changes are on similar lines as the version upstream. We need to rebaseline the expectations as the line numbers differ in test shell and dumprendertree. The document-open.html crashes in test_shell as this test causes the existing document to be taken down which takes down the plugin instance and the associated plugin stream. This works in the webkit plugin implementation as they grab a reference on the plugin stream before calling into the plugin to protect from the stream being destroyed. Our fix is on similar lines. Bug=27164 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31991

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -41 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/plugins/document-open-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/plugins/window-open-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/plugins/document-open-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/plugins/window-open-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/plugins/document-open-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/plugins/window-open-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_stream_url.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_string_stream.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/PluginObject.h	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/PluginObject.cpp	View	1	3 chunks	+127 lines, -0 lines	0 comments	Download
M	webkit/tools/npapi_layout_test_plugin/main.cpp	View		4 chunks	+16 lines, -41 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 393017: This CL fixes the document-open.html and window-open.html plugin layout tests... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages