Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp - Issue 392993005: Custom handlers should throw SecurityError exception if the URL's origin differs from the document'…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp

Issue 392993005: Custom handlers should throw SecurityError exception if the URL's origin differs from the document'… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Done Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h ('k') | Source/web/NavigatorContentUtilsClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp

diff --git a/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp b/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp

index 1319a3d2910330214642289fd1f6141aa8290eda..77995dad4a2877bd412c9be1f4e43341e9eabc42 100644

--- a/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp

+++ b/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp

@@ -11,12 +11,11 @@

namespace blink {

-void NavigatorContentUtilsClientMock::registerProtocolHandler(const String& scheme, const KURL& baseURL,

+void NavigatorContentUtilsClientMock::registerProtocolHandler(const String& scheme,

const KURL& url, const String& title)

{

ProtocolInfo info;

info.scheme = scheme;

- info.baseURL = baseURL;

info.url = url;

info.title = title;

@@ -24,7 +23,7 @@ void NavigatorContentUtilsClientMock::registerProtocolHandler(const String& sche

}

NavigatorContentUtilsClient::CustomHandlersState NavigatorContentUtilsClientMock::isProtocolHandlerRegistered(const String& scheme,

- const KURL& baseURL, const KURL& url)

+ const KURL& url)

{

// "declined" state is checked by NavigatorContentUtils::isProtocolHandlerRegistered() before calling this function.

if (m_protocolMap.contains(scheme))

@@ -33,7 +32,7 @@ NavigatorContentUtilsClient::CustomHandlersState NavigatorContentUtilsClientMock

return NavigatorContentUtilsClient::CustomHandlersNew;

}

-void NavigatorContentUtilsClientMock::unregisterProtocolHandler(const String& scheme, const KURL& baseURL,

+void NavigatorContentUtilsClientMock::unregisterProtocolHandler(const String& scheme,

const KURL& url)

{

m_protocolMap.remove(scheme);