public/web/WebViewClient.h - Issue 392993005: Custom handlers should throw SecurityError exception if the URL's origin differs from the document'…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebViewClient.h

Issue 392993005: Custom handlers should throw SecurityError exception if the URL's origin differs from the document'… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp ('K') | « Source/web/NavigatorContentUtilsClientImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/web/WebViewClient.h

diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h

index 1dd399a02bd19b93d48050c256794d7291d6d784..23a4b3cc182e6bdbb9ccd1145ef3047ec585e3ff 100644

--- a/public/web/WebViewClient.h

+++ b/public/web/WebViewClient.h

@@ -263,15 +263,14 @@ public:

// Registers a new URL handler for the given protocol.

virtual void registerProtocolHandler(const WebString& scheme,

- const WebURL& baseUrl,

const WebURL& url,

const WebString& title) { }

// Unregisters a given URL handler for the given protocol.

- virtual void unregisterProtocolHandler(const WebString& scheme, const WebURL& baseUrl, const WebURL& url) { }

+ virtual void unregisterProtocolHandler(const WebString& scheme, const WebURL& url) { }

// Check if a given URL handler is registered for the given protocol.

- virtual WebCustomHandlersState isProtocolHandlerRegistered(const WebString& scheme, const WebURL& baseUrl, const WebURL& url)

+ virtual WebCustomHandlersState isProtocolHandlerRegistered(const WebString& scheme, const WebURL& url)

{

return WebCustomHandlersNew;

}

« Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp ('K') | « Source/web/NavigatorContentUtilsClientImpl.cpp ('k') | no next file » | no next file with comments »