Custom handlers should throw SecurityError exception if the URL's origin differs from the document'…

public/web/WebViewClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 243 matching lines @@
 
     // Informs the browser that the zoom level has changed as a result of an
     // action that wasn't initiated by the client.
     virtual void zoomLevelChanged() { }
 
 
     // Navigator Content Utils  --------------------------------------------
 
     // Registers a new URL handler for the given protocol.
     virtual void registerProtocolHandler(const WebString& scheme,
-        const WebURL& baseUrl,
         const WebURL& url,
         const WebString& title) { }
 
     // Unregisters a given URL handler for the given protocol.
-    virtual void unregisterProtocolHandler(const WebString& scheme, const WebURL& baseUrl, const WebURL& url) { }
+    virtual void unregisterProtocolHandler(const WebString& scheme, const WebURL& url) { }
 
     // Check if a given URL handler is registered for the given protocol.
-    virtual WebCustomHandlersState isProtocolHandlerRegistered(const WebString& scheme, const WebURL& baseUrl, const WebURL& url)
+    virtual WebCustomHandlersState isProtocolHandlerRegistered(const WebString& scheme, const WebURL& url)
     {
         return WebCustomHandlersNew;
     }

[abarth-chromium, 2014/08/20 18:15:10]

Is Chromium prepared to handle this API change or will this break the feature?

[pals, 2014/08/21 14:02:56]

I am not sure what is the best way to land this change. I have created a CL to
prepare chromium to land this CL, https://codereview.chromium.org/485103005/. I
shall create a follow up CL to remove the overridden methods. This will need an
extra commit.

I have also created this CL https://codereview.chromium.org/428253006/ if we can
somehow land both the CLs bypassing the trybots.

 
 
     // Visibility -----------------------------------------------------------
 
     // Returns the current visibility of the WebView.
     virtual WebPageVisibilityState visibilityState() const
     {
         return WebPageVisibilityStateVisible;
     }
 
@@ skipping 22 matching lines @@
     // Informs the browser that the draggable regions have been updated.
     virtual void draggableRegionsChanged() { }
 
 protected:
     ~WebViewClient() { }
 };
 
 } // namespace blink
 
 #endif