Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/search/suggestions/thumbnail_manager.cc

Issue 392983007: [Suggestions] Make ThumbnailManager implement ImageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/suggestions/thumbnail_manager.cc
diff --git a/chrome/browser/search/suggestions/thumbnail_manager.cc b/chrome/browser/search/suggestions/thumbnail_manager.cc
index 663827e206da57f90ac6c6440bb1700b15c7abde..abe97fdd0092ae5f27eb0aafa2b6383f9d04eb7f 100644
--- a/chrome/browser/search/suggestions/thumbnail_manager.cc
+++ b/chrome/browser/search/suggestions/thumbnail_manager.cc
@@ -18,7 +18,8 @@ namespace {
SkBitmap* DecodeThumbnail(const std::vector<unsigned char>& encoded_data) {
return gfx::JPEGCodec::Decode(&encoded_data[0], encoded_data.size());
}
-}
+
+} // namespace
namespace suggestions {
@@ -45,8 +46,7 @@ ThumbnailManager::ThumbnailRequest::ThumbnailRequest(chrome::BitmapFetcher* f)
ThumbnailManager::ThumbnailRequest::~ThumbnailRequest() { delete fetcher; }
-void ThumbnailManager::InitializeThumbnailMap(
- const SuggestionsProfile& suggestions) {
+void ThumbnailManager::Initialize(const SuggestionsProfile& suggestions) {
thumbnail_url_map_.clear();
for (int i = 0; i < suggestions.suggestions_size(); ++i) {
const ChromeSuggestion& suggestion = suggestions.suggestions(i);
@@ -56,7 +56,7 @@ void ThumbnailManager::InitializeThumbnailMap(
}
}
-void ThumbnailManager::GetPageThumbnail(
+void ThumbnailManager::GetImageForURL(
const GURL& url,
base::Callback<void(const GURL&, const SkBitmap*)> callback) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
@@ -68,7 +68,7 @@ void ThumbnailManager::GetPageThumbnail(
return;
}
- // |database_| can be null if something went wrong in initialization.
+ // |database_| can be NULL if something went wrong in initialization.
if (database_.get() && !database_ready_) {
// Once database is initialized, it will serve pending requests from either
// cache or network.

Powered by Google App Engine
This is Rietveld 408576698