Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6829)

Unified Diff: chrome/browser/search/suggestions/suggestions_service_unittest.cc

Issue 392983007: [Suggestions] Make ThumbnailManager implement ImageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/suggestions/suggestions_service_unittest.cc
diff --git a/chrome/browser/search/suggestions/suggestions_service_unittest.cc b/chrome/browser/search/suggestions/suggestions_service_unittest.cc
index 889ad2501850754ffd4be24fbc84d830adcb9fa7..395eb4d50b3455341963039a09718e541155f23f 100644
--- a/chrome/browser/search/suggestions/suggestions_service_unittest.cc
+++ b/chrome/browser/search/suggestions/suggestions_service_unittest.cc
@@ -14,6 +14,7 @@
#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/search/suggestions/blacklist_store.h"
+#include "chrome/browser/search/suggestions/image_manager.h"
#include "chrome/browser/search/suggestions/proto/suggestions.pb.h"
#include "chrome/browser/search/suggestions/suggestions_service_factory.h"
#include "chrome/browser/search/suggestions/suggestions_store.h"
@@ -32,6 +33,7 @@ using testing::DoAll;
using ::testing::Eq;
using ::testing::Return;
using testing::SetArgPointee;
+using ::testing::NiceMock;
using ::testing::StrictMock;
using ::testing::_;
@@ -100,12 +102,12 @@ class MockSuggestionsStore : public suggestions::SuggestionsStore {
MOCK_METHOD0(ClearSuggestions, void());
};
-class MockThumbnailManager : public suggestions::ThumbnailManager {
+class MockImageManager : public suggestions::ImageManager {
public:
- MockThumbnailManager() {}
- virtual ~MockThumbnailManager() {}
- MOCK_METHOD1(InitializeThumbnailMap, void(const SuggestionsProfile&));
- MOCK_METHOD2(GetPageThumbnail,
+ MockImageManager() {}
+ virtual ~MockImageManager() {}
+ MOCK_METHOD1(Initialize, void(const SuggestionsProfile&));
+ MOCK_METHOD2(GetImageForURL,
void(const GURL&,
base::Callback<void(const GURL&, const SkBitmap*)>));
};
@@ -184,11 +186,11 @@ class SuggestionsServiceTest : public testing::Test {
// SuggestionsStore in |mock_suggestions_store_|.
SuggestionsService* CreateSuggestionsServiceWithMocks() {
mock_suggestions_store_ = new StrictMock<MockSuggestionsStore>();
- mock_thumbnail_manager_ = new StrictMock<MockThumbnailManager>();
+ mock_thumbnail_manager_ = new NiceMock<MockImageManager>();
mock_blacklist_store_ = new MockBlacklistStore();
return new SuggestionsService(
request_context_, scoped_ptr<SuggestionsStore>(mock_suggestions_store_),
- scoped_ptr<ThumbnailManager>(mock_thumbnail_manager_),
+ scoped_ptr<ImageManager>(mock_thumbnail_manager_),
scoped_ptr<BlacklistStore>(mock_blacklist_store_));
}
@@ -248,7 +250,7 @@ class SuggestionsServiceTest : public testing::Test {
net::FakeURLFetcherFactory factory_;
// Only used if the SuggestionsService is built with mocks. Not owned.
MockSuggestionsStore* mock_suggestions_store_;
- MockThumbnailManager* mock_thumbnail_manager_;
+ MockImageManager* mock_thumbnail_manager_;
MockBlacklistStore* mock_blacklist_store_;
scoped_refptr<net::TestURLRequestContextGetter> request_context_;

Powered by Google App Engine
This is Rietveld 408576698